Conversation
MQ + Hack dual-model analysis (Opus 4.6 + Codex 5.3) findings and fixes: HIGH: - MCP handlers bypass Key Vault secret resolution (CWE-522) - Secret filtering denylist incomplete - added PAT, SAS, SIGNING, PRIVATE, PASSPHRASE, AUTH (CWE-532) - New() silently ignoring validation errors - now returns error (CWE-754) MEDIUM: - Shell name case sensitivity causing fallback issues (CWE-178) - Dead path traversal check removed (CWE-561) - Deprecated // +build directives replaced with //go:build (CWE-477) Changed New() signature to return error, updated 30+ callers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Website Preview Your PR preview is ready! 📎 Preview URL: https://jongio.github.io/azd-exec/pr/41/ This preview will be automatically cleaned up when the PR is closed. |
Contributor
🚀 Test This PRA preview build ( 🌐 Website PreviewLive Preview: https://jongio.github.io/azd-exec/pr/41/ One-Line Install (Recommended)PowerShell (Windows): iex "& { $(irm https://raw.githubusercontent.com/jongio/azd-exec/main/cli/scripts/install-pr.ps1) } -PrNumber 41 -Version 0.4.0-pr41"Bash (macOS/Linux): curl -fsSL https://raw.githubusercontent.com/jongio/azd-exec/main/cli/scripts/install-pr.sh | bash -s 41 0.4.0-pr41UninstallWhen you're done testing: PowerShell (Windows): iex "& { $(irm https://raw.githubusercontent.com/jongio/azd-exec/main/cli/scripts/uninstall-pr.ps1) } -PrNumber 41"Bash (macOS/Linux): curl -fsSL https://raw.githubusercontent.com/jongio/azd-exec/main/cli/scripts/uninstall-pr.sh | bash -s 41Build Info:
What to Test: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MQ + Hack Analysis (Dual-Model: Opus 4.6 + Codex 5.3)
HIGH
MEDIUM
12 files changed, +260/-87 lines