fix: reduce dead space in blog feed section#63
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
Agent-Logs-Url: https://github.com/jaypatrick/jk.com/sessions/9d7b1782-8b6a-48d4-8965-9a185a781635 Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jaypatrick
May 25, 2026 02:47
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces excess vertical whitespace in the homepage/blog feed “Latest Thoughts” section by tightening spacing and constraining card excerpt height.
Changes:
- Reduced the heading-row bottom margin (
mb-10→mb-6) to tighten spacing above the grid. - Added a component-scoped section padding override to keep top/bottom padding at 4rem on desktop.
- Added a 4-line clamp to
.feed-descto reduce tall-card-driven row height in the grid.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
265
to
+270
| margin-bottom: 1.25rem; | ||
| flex: 1; | ||
| display: -webkit-box; | ||
| -webkit-line-clamp: 4; | ||
| -webkit-box-orient: vertical; | ||
| overflow: hidden; |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the excess vertical whitespace ("dead space") reported in the blog feed section.
Changes in
src/components/sections/RssFeed.svelte1. Tighten section padding (desktop)
Added a scoped CSS override that caps the section's top/bottom padding at 4 rem on all screen sizes, replacing the global
section-padrule that applied 6 rem on≥1024 pxscreens. The section still keepsclass="section-pad"so mobile spacing (4 rem) is unchanged.2. Reduce heading-row bottom margin
Changed the heading div from
mb-10(2.5 rem / 40 px) tomb-6(1.5 rem / 24 px). Unlike Services and Portfolio — which fill their heading block with a subtitle paragraph — the blog feed heading only contains the<h2>and the "View all posts" link, so the larger margin was creating unnecessary dead space before the card grid.3. Clamp description text (
-webkit-line-clamp: 4)Added a 4-line clamp to
.feed-desc. Without this, CSS Grid equalises row heights to match the tallest card, and cards with short excerpts end up with a large blank area inside their description element (whereflex: 1stretches the<p>tag). The clamp caps the visible text so descriptions stay visually consistent across cards.Testing
npm test)npm run build)