-
Notifications
You must be signed in to change notification settings - Fork 92
Update MIDI docs for GUI tab #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ignotus666
wants to merge
2
commits into
jamulussoftware:next-release
Choose a base branch
from
ignotus666:midi-upd
base: next-release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://github.com/user-attachments/assets/2f14110c-5e73-4416-b8dc-f326fe3b5f3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://github.com/user-attachments/assets/2f14110c-5e73-4416-b8dc-f326fe3b5f3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://github.com/user-attachments/assets/2f14110c-5e73-4416-b8dc-f326fe3b5f3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://github.com/user-attachments/assets/2f14110c-5e73-4416-b8dc-f326fe3b5f3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://github.com/user-attachments/assets/2f14110c-5e73-4416-b8dc-f326fe3b5f3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://github.com/user-attachments/assets/2f14110c-5e73-4416-b8dc-f326fe3b5f3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://github.com/user-attachments/assets/2f14110c-5e73-4416-b8dc-f326fe3b5f3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://github.com/user-attachments/assets/2f14110c-5e73-4416-b8dc-f326fe3b5f3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://github.com/user-attachments/assets/2f14110c-5e73-4416-b8dc-f326fe3b5f3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://github.com/user-attachments/assets/2f14110c-5e73-4416-b8dc-f326fe3b5f3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://github.com/user-attachments/assets/2f14110c-5e73-4416-b8dc-f326fe3b5f3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://github.com/user-attachments/assets/2f14110c-5e73-4416-b8dc-f326fe3b5f3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://github.com/user-attachments/assets/2f14110c-5e73-4416-b8dc-f326fe3b5f3d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| - `-M` or `--mutestream` Prevent others on a server from hearing what I play | ||
| - `--mutemyown` Prevent me from hearing what I play in the server mix (headless only) | ||
| - `-c` or `--connect` Connect to given server address on startup, format `address[:port]` | ||
| - `-j` or `--nojackconnect` Disable auto JACK connections | ||
| - `--ctrlmidich` MIDI channel to listen on, Jamulus control + MIDI control number and count of consecutive CC numbers (or Jamulus channels), device selection option. Format: `channel[;fn[*n]][;pn[*n]][;sn[*n]][;mn[*n]][;on][;dDeviceName]` See [Tips & Tricks](Tips-Tricks-More#using---ctrlmidich-for-midi-controllers). | ||
| - `-M` or `--mutestream` Prevent others on a server from hearing what I play | ||
| - `--mutemyown` Prevent me from hearing what I play in the server mix (headless only) | ||
| - `-c` or `--connect` Connect to given server address on startup, format `address[:port]` | ||
| - `-j` or `--nojackconnect` Disable auto JACK connections | ||
| - `--ctrlmidich` MIDI channel to listen on, Jamulus control + MIDI control number and count of consecutive CC numbers (or Jamulus channels), pick-up mode, device selection option. Format: `channel[;fn[*n]][;pn[*n]][;sn[*n]][;mn[*n]][;on][;u][;dDeviceName]` See [Tips & Tricks](Tips-Tricks-More#using---ctrlmidich-for-midi-controllers). | ||
| - `--clientname` Window title and JACK client name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be the case.
I thought we'd said the default was to have MIDI disabled -- i.e. not change in current behaviour.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand; the current behaviour is precisely that: if there are any MIDI devices present and none have been specified on the command line (or saved), it will connect to all of them. Note that the paragraph starts with "With MIDI-in enabled".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it doesn't.
If I run
Jamuluswithout parameters, no version will even consider opening a MIDI device.That behaviour should be the default.
Of course, if I say `Jamulus --ctrlmidich '1;', all versions will go find all available MIDI devices to listen on channel 1.
See the difference? In the first case, Jamulus did what Jamulus had always done before
--ctrlmidichwas introduced: took no notice of MIDI. Only when the user explicitly requested use of MIDI did Jamulus go looking for devices.The UI needs to retain that model.
Starting up with
Jamulus, having taken no notice in the past and having no intention of taking any notice in future of MIDI should not cause any change in behaviour -- Jamulus must not start doing something with MIDI devices because of this change.If the user then sees there's a new feature, opens MIDI settings and chooses to enable MIDI - just like they might have chosen to use
--ctrlmidich-- then yes, Jamulus will go hunting down those MIDI devices, just the same.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a user installs Jamulus and has never used MIDI nor intends to, when they launch it MIDI will be disabled, and will continue to be disabled until they enable it. I'm sorry but I don't see where it's implied otherwise.
No, only the non-Jack Windows version will do that. The others will default to "No device connected" or if there was one saved previously, to that.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That explicitly tells the user their MIDI devices get connected, doesn't it? Regardless of any choice.
Then how did they work before the optional
;ddevicewas added?Remember - I'm concerned with changes from 3.11.0 - before the UI or preferences existed.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You had to make the connection manually using an external connection manager (e.g. QJackctl). Non-Jack Windows just connected to all available devices.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-JACK Windows didn't have MIDI in 3.11.0:
So, no, non-JACK Windows did not "just connect to all available devices". The
;dwas added in the same change.Even with that change, unless explicitly requested, MIDI wasn't started.
That doesn't just apply to Windows:
The default was and needs to remain that -- unless the user explicitly requests use of MIDI -- MIDI is not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok my bad - since it was there when I started work on this I assumed it'd been in since the previous release. But then it's a moot issue: no change in behaviour from 3.11 since there wasn't any behaviour.
But this is what happens. The only difference now is that if you've enabled MIDI (and not disabled it again), the enabled state will persist across restarts without adding
--ctrlmidich. This is what currently happens with some other settings. In fact you can disable MIDI again on the CLI withjamulus --ctrlmidich '-1'or any other invalid channel number; even an empty string will do. If you set e.g. delay panning for the server with the CLI, how do you disable it other than via the GUI? It will stay enabled across restarts even if you omit the-Poption. What doesn't make any sense to me is to have to explicitly keep enabling a setting every time I fire up an application. If I've set something to "enabled", particularly if it's in the GUI, I'd expect it to stay that way until I explicitly disable it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've written this in the docs:
Now you're contradicting it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be helpful if you could point out where this contradiction is, because I don't see it.
This is the quote you keep referencing with the key bit of context added: