Skip to content

Use safe_load in formats#438

Draft
EhteshamSid wants to merge 1 commit into
jacebrowning:mainfrom
EhteshamSid:fix/use-safe-load-in-formats
Draft

Use safe_load in formats#438
EhteshamSid wants to merge 1 commit into
jacebrowning:mainfrom
EhteshamSid:fix/use-safe-load-in-formats

Conversation

@EhteshamSid
Copy link
Copy Markdown

yaml.load() in datafiles/formats.py doesn't pass a safe Loader. This can deserialize arbitrary Python objects and is an RCE risk if the YAML comes from user input or the network. Switched to yaml.safe_load().

@jacebrowning jacebrowning self-requested a review April 8, 2026 21:17
Copy link
Copy Markdown
Owner

@jacebrowning jacebrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That function doesn't exist. Please run the tests.

@jacebrowning jacebrowning marked this pull request as draft May 1, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants