Add SetBuilder for batched gNMI Set operations#445
Open
felix-kaestner wants to merge 1 commit into
Open
Conversation
felix-kaestner
commented
Jul 15, 2026
| cp "github.com/felix-kaestner/copy" | ||
| "github.com/go-logr/logr" | ||
| gpb "github.com/openconfig/gnmi/proto/gnmi" | ||
| gnmipb "github.com/openconfig/gnmi/proto/gnmi" |
Contributor
Author
There was a problem hiding this comment.
"pb" is the canonical suffix for packages exposing protobuf generated grpc client/server code. ref/ https://pkg.go.dev/google.golang.org/protobuf/types/known
Introduce a SetBuilder type that accumulates update, patch, and delete operations to be executed as a single gNMI Set RPC via the new Client.Do method. This allows atomic multi-operation commits without multiple round-trips to the device. An optional Limit method controls the maximum number of operations per SetRequest, splitting into multiple RPCs when set. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
felix-kaestner
force-pushed
the
refactor/gnmiext
branch
from
0625c82 to
9b6aad6
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a SetBuilder type that accumulates update, patch, and delete operations to be executed as a single gNMI Set RPC via the new Client.Do method. This allows atomic multi-operation commits without multiple round-trips to the device.
An optional Limit method controls the maximum number of operations per SetRequest, splitting into multiple RPCs when set.