Use events.k8s.io API group for RBAC event permissions#288
Open
felix-kaestner wants to merge 2 commits intonxapifrom
Open
Use events.k8s.io API group for RBAC event permissions#288felix-kaestner wants to merge 2 commits intonxapifrom
felix-kaestner wants to merge 2 commits intonxapifrom
Conversation
hardikdr
added
the
area/switch-automation
Replace kerrors.NewAggregate with stdlib errors.Join in the nxos provider and ctrl.LoggerFrom with logr.FromContextOrDiscard in the openconfig provider, enforcing the boundary that provider code must not depend on k8s.io packages.
The event recorder uses k8s.io/client-go/tools/events which creates events via the events.k8s.io API group. Replace the legacy core API group with events.k8s.io in all kubebuilder RBAC markers and regenerate manifests.
felix-kaestner
force-pushed
the
refactor/events-api-group
branch
from
dac05fb to
6aa3f26
Compare
nikatza
approved these changes
Apr 9, 2026
sven-rosenzweig
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The event recorder uses k8s.io/client-go/tools/events which
creates events via the events.k8s.io API group. Replace the
legacy core API group with events.k8s.io in all kubebuilder
RBAC markers and regenerate manifests.