Merged
Conversation
friegger
approved these changes
Jan 30, 2026
Contributor
There was a problem hiding this comment.
LGTM. Once the test setup has improved we can have a controller test for this and also a test that verifies that the fields get properly converted from the IRI machine to the API machine.
Replicates ironcore-dev/libvirt-provider#655
# Conflicts: # go.mod # go.sum
lukasfrank
force-pushed
the
feat/local-disk
branch
3 times, most recently
from
1f6ad8f to
97b685e
Compare
lukasfrank
force-pushed
the
feat/local-disk
branch
3 times, most recently
from
4e7cff8 to
46daa4f
Compare
lukasfrank
force-pushed
the
feat/local-disk
branch
from
46daa4f to
c6b1c58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
LocalDiskFixes #141