Skip to content

Support new iPython system_raise_on_error flag in ZMQInteractiveShell #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adityawasudeo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support new iPython system_raise_on_error flag in ZMQInteractiveShell #1496

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d93f431
Support system_raise_on_error in ZMQInteractiveShell
adityawasudeo Nov 14, 2025
445c366
Add support for IPython's system_raise_on_error
adityawasudeo Feb 19, 2026
5acbbb9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ipykernel/zmqshell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import typing
import warnings
from pathlib import Path
from subprocess import CalledProcessError

from IPython.core import page
from IPython.core.autocall import ZMQExitAutocall
Expand Down Expand Up @@ -783,9 +784,14 @@ def system_piped(self, cmd):
with AvoidUNCPath() as path:
if path is not None:
cmd = f"pushd {path} &&{cmd}"
self.user_ns["_exit_code"] = system(cmd)
exit_code = system(cmd)
self.user_ns["_exit_code"] = exit_code
else:
self.user_ns["_exit_code"] = system(self.var_expand(cmd, depth=1))
exit_code = system(self.var_expand(cmd, depth=1))
self.user_ns["_exit_code"] = exit_code

if getattr(self, "system_raise_on_error", False) and exit_code != 0:
raise CalledProcessError(exit_code, cmd)

# Ensure new system_piped implementation is used
system = system_piped
Expand Down
Loading