Replaced PUB socket with XPUB socket#1482
Conversation
JohanMabille
force-pushed
the
xpub
branch
6 times, most recently
from
32550f8 to
8be7770
Compare
|
This needs spyder-ide/qtconsole#644 and a release of qtconsole. |
|
It's been a few weeks areadly. I propose that we disable the qtconsole downstream tests, until we hear back from the team. |
As suggested [here](#1482 (comment)), this removes the spyder downstream tests to avoid delaying more the PRs on ipykernel. Done in a dedicated PR so it's easier to retrieve this change in the history if we need to add them back at some point.
|
This is in the 7.2.0a0 prerelease so that is can be fully tested. |
Sorry for the unresponsiveness but I'd also like to say that, even if I were available, tests in spyder-ide/qtconsole#644 are not passing, so I couldn't merge that PR. |
|
Which test do not pass? I see every job green. |
| """ | ||
|
|
||
| def __init__(self, socket, pipe=False): | ||
| def __init__(self, socket, session=None, pipe=False): |
There was a problem hiding this comment.
Since this is a breaking API change, let's make sure this is a major version bump
Sorry, when I posted my message a couple of tests were failing. However, those tests passed after a rerun. By the way, I thought your PR automatically triggered our CIs, so I assumed it broke our tests. But it turns out a member of our team did that (I just didn't notice it). |
|
@JohanMabille, we sent you an invite to be collaborator in the QtConsole repo to avoid this situation in the future. As long as CIs are green, you should be able to merge PRs there. |
|
@ccordoba12 Thanks a lot! |
5 participants
This implements the XPUB JEP in ipykernel.