This repository was archived by the owner on May 4, 2022. It is now read-only.
fix(modal): fix the wrong condition of modalStack#323
Open
aleen42 wants to merge 1 commit intoionic-team:masterfrom
Open
fix(modal): fix the wrong condition of modalStack#323aleen42 wants to merge 1 commit intoionic-team:masterfrom
aleen42 wants to merge 1 commit intoionic-team:masterfrom
Conversation
aleen42
force-pushed
the
master
branch
2 times, most recently
from
acf5423 to
cab9fd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
It seems that the body of ionic should remove the class
modal-open, but if using!modalStack.length, it failes to do this whenmodalStack.length > 0. In my opinion, it should be fixed as followed:In addition, if check modal stack whether it is empty when timeout function is fired, the stack will be cleared, resulting in wrong process. Therefore, we need to assign it to a variable outside.Actually, I have found that
modal-openclass is not absolutely related to the modalStack, which means that we can not easily use the length of modalStack to judge whether we should remove the class namemodal-open.Changes proposed in this pull request:
Ionic Version: 1.3.2
Fixes: #