This repository was archived by the owner on May 4, 2022. It is now read-only.
add Enter keypress to ionic popups#240
Open
gabrielbazan7 wants to merge 1 commit intoionic-team:masterfrom
Open
add Enter keypress to ionic popups#240gabrielbazan7 wants to merge 1 commit intoionic-team:masterfrom
gabrielbazan7 wants to merge 1 commit intoionic-team:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
$ionicPopup.prompt does not support the Enter and Escape key. I found this PR ionic-team/ionic-framework#4739. I test it and the enter button works as expected. So I think could be useful.
Changes proposed in this pull request:
Enter is triggered by the Go/Enter button on the software keyboard, and expected behavior would be to click the OK button for you.
Ionic Version: 1.x
Fixes: #