This repository was archived by the owner on May 4, 2022. It is now read-only.
Don't add keyboard-open to CSS if keyboard is already hidden#201
Open
sryze wants to merge 1 commit intoionic-team:masterfrom
sryze:kill-keyboard-open-timer
Open
Don't add keyboard-open to CSS if keyboard is already hidden#201sryze wants to merge 1 commit intoionic-team:masterfrom sryze:kill-keyboard-open-timer
sryze wants to merge 1 commit intoionic-team:masterfrom
sryze:kill-keyboard-open-timer
Conversation
The 'keyboard-open' CSS class is added to body after a 400ms delay, but nothing stops somebody from hiding the keyboard during this short period of time, for example by tapping on empty space. So we need to kill the timer responsible for adding this class when the keyboard hides. See this comment for some more details: ionic-team/ionic-framework#3041 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
The 'keyboard-open' CSS class is added to body after a 400ms delay, but nothing stops somebody from hiding the keyboard during this short period of time, for example by tapping on empty space.
Changes proposed in this pull request:
Ionic Version: 1.x
See this comment for some more details:
ionic-team/ionic-framework#3041 (comment)