fix(datetime-button): fix initial text not obeying datetime constraints#31218
Open
droc101 wants to merge 1 commit into
Open
fix(datetime-button): fix initial text not obeying datetime constraints#31218droc101 wants to merge 1 commit into
droc101 wants to merge 1 commit into
Conversation
…aints expose new `getClosestDate(date: Date) => Promise<Date>` function in the Datetime class and use it in DatetimeButton to round the current time (default value) into a date that matches the constraints provided on the Datetime element (dayValues, minuteValues, etc.) closes ionic-team#30183
|
@droc101 is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
package: core
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30183
What is the current behavior?
an
IonDatetimeButton's default value (such as when .value is undefined) always uses the exact current date & time, regardless of any restrictions requested by the associatedIonDatetime(such as only allowing 5 minute increments)What is the new behavior?
IonDatetimeButtonnow follows the constraints on its associatedIonDatetime.valueof theIonDatetimeButtonis unchangedasync getClosestDate(date: Date) => Promise<Date>has been added toIonDatetimeto facilitate this change. If this should not be a public method, I can work on changing that.getClosestDatetimeParts(parts: DatetimeParts) => DatetimePartshas been added toIonDatetimeas a helper to the previously mentionedgetClosestDatemethod, and to deduplicate code.Does this introduce a breaking change?