feat(item-sliding): added specific animations for ionic#31103
Open
os-davidlourenco wants to merge 6 commits intonextfrom
Open
feat(item-sliding): added specific animations for ionic#31103os-davidlourenco wants to merge 6 commits intonextfrom
os-davidlourenco wants to merge 6 commits intonextfrom
Conversation
os-davidlourenco
added
package: core
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
removed
package: angular
os-davidlourenco
force-pushed
the
ROU-12715
branch
from
6dc87ba to
a247ac5
Compare
os-davidlourenco
force-pushed
the
ROU-12715
branch
from
c2f1465 to
7468b4c
Compare
BenOsodrac
requested changes
Apr 30, 2026
|
|
||
| // Transition utility classes | ||
| .item-sliding-transition-open .item { | ||
| transition: transform 250ms cubic-bezier(0.25, 1, 0.5, 1); |
Contributor
There was a problem hiding this comment.
We should be using tokens here, we already have some for the time and cubic bezier. If the cubic-bezier ones don't match with what we need here, please align with Mariana to see if it makes sense to create a new token, like @joselrio did recently
Contributor
Author
There was a problem hiding this comment.
I talked with Mariana regarding this one she said that no existing token is compatible with this. I will ask if it makes sense to create a new token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
The
item-slidinghas the same animations for md, iOS and IonicWhat is the new behavior?
New animations were added for the Ionic theme, including:
item-slidingitem-slidingNew conditions were also included to ensure a smoother experience:
item-slidingby exceeding velocityDoes this introduce a breaking change?
Other information