-
Notifications
You must be signed in to change notification settings - Fork 3.2k
docs(react-router): updating docs to reflect react router 6 changes #4422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: major-9.0
Are you sure you want to change the base?
Changes from all commits
2b442d1
8fcf1cf
bcf73fe
12981ad
1bd69b1
d0f6f2f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding this here so it has a thread: Don't we need to update the playgrounds as well or is that going to be done on a separate PR? See: ionic-docs/static/usage/v9/tabs/router/react/main_tsx.md Lines 19 to 30 in 1307564
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Excellent catch! Didn't even realize there were playgrounds for RR6. Fixed in d0f6f2f
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you also plan to update the React router dependencies here: ionic-docs/static/code/stackblitz/v9/react/package.json Lines 11 to 12 in 1307564
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't change this here since it is the same on all of the other framework guides, unless you plan on updating all of them:
ionic-docs/docs/vue/add-to-existing.md
Line 64 in d997c6b
ionic-docs/docs/angular/add-to-existing.md
Line 79 in d997c6b