fix: Behavior for API below 26#4
Open
OS-pedrogustavobilro wants to merge 4 commits intofeat/RMET-4099/android-implementationfrom
Open
fix: Behavior for API below 26#4OS-pedrogustavobilro wants to merge 4 commits intofeat/RMET-4099/android-implementationfrom
OS-pedrogustavobilro wants to merge 4 commits intofeat/RMET-4099/android-implementationfrom
Conversation
OutSystems requires 28, Capacitor requires 24, none requires 23.
Contributor
Author
|
FYI @OS-ruimoreiramendes @alexgerardojacinto, I'm comparing this against the branch in #3 (if I did it against the unification branch would have to resolve conflicts later). We can wait til the other PR is merged, then switch the branch in this one and merge it after |
alexgerardojacinto
approved these changes
Mar 13, 2026
Base automatically changed from
feat/RMET-4099/edit-media-processor
to
feat/RMET-4099/android-implementation
March 16, 2026 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the library was accessing APIs available only in 26, but minSdk of library is below 26.
These APIs were for getting file creation date (for
MediaResult#Metadata). The 3 options I saw to overcome this:I ended up going with option 2. This allows to still return relevant information for
Metadata, and is simpler than enabling core library desugaring - we didn't do this either for FileSystem (see docs for ctime), and since it's just a couple API levels that are pretty old, I think this option is fine.This Lib currently had minSdk 23, I updated to 24, also updated compileSdk and targetSdk, to match current native library that this one is ported from.
Context
Capacitor has minSdk 24, but current native libary had minSdk 26, the one incompatibility was in Java NIO file APIs available only in minSdk 26 (without core library desugaring)
Type of changes