fix(cli): add system framework and weak framework support in SPM Package.swift#8447
Merged
OS-ruimoreiramendes merged 4 commits intomainfrom May 4, 2026
Merged
Conversation
OS-ruimoreiramendes
requested review from
ItsChaceD,
OS-pedrogustavobilro,
alexgerardojacinto,
andredestro,
jcesarmobile,
markemer and
theproducer
|
Minor: I think the PR title should be |
OS-ruimoreiramendes
changed the title
Member
|
it still shows conflicts |
Contributor
Author
the conflicts are now resolved. They appeared after merging one of the related PRs, but everything is up to date now. |
OS-pedrogustavobilro
approved these changes
May 4, 2026
Contributor
OS-pedrogustavobilro
left a comment
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
LGTM. From my tests this code doesn't seem to add difference for cdv plugins with regular system frameworks (without weak), it seems to work for me without this PR, but from what we discussed internal, that is expected.
OS-ruimoreiramendes
added a commit
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for translating
<framework src="..." />declarations fromplugin.xmlintolinkerSettingsentries in the generatedPackage.swift. Frameworks marked asweak="true"are handled by settingtype: .dynamicon the library product, following the same approach used in ion-ios-camera.Tested with a dummy plugin declaring
SwiftUICore.frameworkwithweak="true", no crash on iOS 15 simulator, successful build on a physical device.Reference: https://outsystemsrd.atlassian.net/browse/RMET-5154