Feature: Add the ability to call a saved workflow from another#9093
Open
JPPhoto wants to merge 157 commits intoinvoke-ai:mainfrom
Open
Feature: Add the ability to call a saved workflow from another#9093JPPhoto wants to merge 157 commits intoinvoke-ai:mainfrom
JPPhoto wants to merge 157 commits intoinvoke-ai:mainfrom
Conversation
* Add per-user workflow isolation: migration 28, service updates, router ownership checks, is_public endpoint, schema regeneration, frontend UI Co-authored-by: lstein <111189+lstein@users.noreply.github.com> * feat: add shared workflow checkbox to Details panel, auto-tag, gate edit/delete, fix tests Co-authored-by: lstein <111189+lstein@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
…mode (invoke-ai#116) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
…ature/workflow-isolation-in-multiuser-mode
… mode (#120) * Disable Save when editing another user's shared workflow in multiuser mode Co-authored-by: lstein <111189+lstein@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
…-board filter, archive Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
…image, etc.) Previously, images in shared boards owned by another user could not be dragged at all — the draggable setup was completely skipped in GalleryImage.tsx when canWriteImages was false. This blocked ALL drop targets including the viewer, reference image pane, and canvas. Now images are always draggable. The board-move restriction is enforced in the dnd target isValid functions instead: - addImageToBoardDndTarget: rejects moves from shared boards the user doesn't own (unless admin or board is public) - removeImageFromBoardDndTarget: same check Other drop targets (viewer, reference images, canvas, comparison, etc.) remain fully functional for shared board images. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…to copilot/enhancement-allow-shared-boards
…-allow-shared-boards' into copilot/enhancement-allow-shared-boards
Stacked on top of origin PR invoke-ai#9018 (shared/private workflows and boards) for multiuser workflow visibility semantics.
7152bff to
11d3eb7
Compare
Collaborator
|
Should this be tagged for 6.13? |
…ches/189885-1777589632/31cb653f40eceef89f75012837b2fcce2fafe2c5
Collaborator
Author
In an ideal world, with enough reviewers, sure. But realistically, the number of reviewers should be >1 and it should hit |
…ches/204380-1777639603/31cb653f40eceef89f75012837b2fcce2fafe2c5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds engine-native
call_saved_workflowsupport. A parent workflow can select a saved workflow, bind values or connections to its exposed fields, suspend at the call node, execute the selected workflow as first-class child queue item(s), capture explicit named return values, and resume the parent workflow.The implementation includes backend call-boundary execution, parent/child queue relationship metadata, access validation, dynamic input binding, bounded nested calls, strict child failure propagation, root-oriented retry behavior, child-row cancel/delete semantics, compatibility reporting, and named workflow returns via
workflow_return_value,workflow_return, andworkflow_return_get.Related Issues / Discussions
This has been discussed many times on Discord.
QA Instructions
New tests in:
Manual return-value test plan (note that this PR includes a database migration!):
integer,workflow_return_value,collect, andworkflow_return.integer.valuetoworkflow_return_value.value.workflow_return_value.keytoresult.workflow_return_value.valuetocollect.item.collect.collectiontoworkflow_return.values.call_saved_workflow,workflow_return_get, and a downstream node such asadd.call_saved_workflow.call_saved_workflow.valuestoworkflow_return_get.values.workflow_return_get.keytoresult.workflow_return_get.valuetoadd.a.add.bto a literal value.add.valueequals the returned child value plusadd.b.For batch behavior, replace the child
integerwithinteger_batchconnected tointeger.value, then return theinteger.valuethrough the sameworkflow_return_valuepath. The parent should receiveresultas a list of returned values.Merge Plan
This branch includes a queue/session migration for workflow-call relationship metadata. Recheck migration ordering against other in-flight migrations before final merge.
Checklist
What's Newcopy (if doing a release after this PR)