fix(cli): ensure generated firebase_options.dart is perfectly formatted#437
Merged
russellwheatley merged 1 commit intoinvertase:mainfrom Apr 24, 2026
Merged
Conversation
- Refine string generation in FirebaseDartConfigurationWrite to match dart format output by construction. - Fix extra newline before closing brace of DefaultFirebaseOptions. - Fix file update logic to remove trailing empty lines and insert content at the correct position. - Ensure the generated file ends with a trailing newline. - Add a golden test for web-only configuration and a test for update logic cleanup. - Refactor tests to reduce code duplication using a helper.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new --firebase-out flag to the flutterfire configure and reconfigure commands, allowing users to specify a custom path for the generated firebase.json file. It also refines the generation of firebase_options.dart by improving whitespace management and ensuring consistent trailing newlines. Comprehensive tests, including a new golden test, have been added to validate the custom output path and the improved file formatting. I have no feedback to provide.
Member
|
Contributor
Author
|
Sorry, @russellwheatley – git commit weirdness. See 4af3db4 Will fix here now! |
github-actions
Bot
added
the
Needs Attention
kevmoo
changed the title
russellwheatley
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refine string generation in FirebaseDartConfigurationWrite to match dart format output by construction.
Fix extra newline before closing brace of DefaultFirebaseOptions.
Fix file update logic to remove trailing empty lines and insert content at the correct position.
Ensure the generated file ends with a trailing newline.
Add a golden test for web-only configuration and a test for update logic cleanup.
Refactor tests to reduce code duplication using a helper.