Skip to content

docs: finalize upgrade guide#2581

Open
git-nandor wants to merge 1 commit into
rework-documentationfrom
ISTUI-4925_finalize_upgrade_guide
Open

docs: finalize upgrade guide#2581
git-nandor wants to merge 1 commit into
rework-documentationfrom
ISTUI-4925_finalize_upgrade_guide

Conversation

@git-nandor
Copy link
Copy Markdown
Contributor

INSTUI-4925

Summary

Add missing New theming system section to the Upgrade guide for v11.7 page

Co-Authored-By: 🤖 Claude

@git-nandor git-nandor self-assigned this Jun 4, 2026
@git-nandor git-nandor marked this pull request as ready for review June 4, 2026 13:59
@git-nandor git-nandor requested review from balzss and matyasf June 4, 2026 13:59
@git-nandor git-nandor changed the title docs: Finalize upgrade guide docs: finalize upgrade guide Jun 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2581/

Built to branch gh-pages at 2026-06-04 14:04 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

github-actions Bot pushed a commit that referenced this pull request Jun 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Visual regression report

No changes.

Status Count
Unchanged 32
Changed 0
New 0
Removed 0

📊 View full report

Baselines come from the visual-baselines branch. They refresh on every merge to master.

Copy link
Copy Markdown
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

## New theming system

NOTE: this section is under development, will be updated soon
InstUI v11.7 introduces a token-based theming engine. Components imported from `/v11_7` (the `v2` label in the docs "Component version" selector) consume pre-resolved design tokens directly from the active theme. Components imported from `/v11_6` (the `v1` label) continue to use the legacy `generateComponentTheme` approach. **Both engines run side-by-side in the same app without conflict** — you can migrate component-by-component on your own schedule.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InstUI v11.7 introduces a token-based theming engine ->
InstUI v11.7 introduces a new theming engine. Components imported from /v11_7 (the v2 label in the docs "Component version" selector) consume design tokens directly from the active theme.


4. **Update per-component theme overrides.** Many v2 components have renamed / added / removed tokens — see the component-specific sections below for the exact changes.

> Components that haven't yet been promoted to v2 (`DateInput2`, `Editable`) ship as `v1` even when imported from `/v11_7` and continue to use legacy theming. The two engines coexist transparently — no special handling needed.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no such components now. Editable does not have a theme, this might've confused the AI, and DateInput2 is replaced

Comment on lines +36 to +39
What changed is the **shape** of the override:

- **Legacy** — at both entry points, `themeOverride` accepted the component's flat theme-variable map (object or function returning one).
- **New** — provider-level `themeOverride` is a structured object keyed by token layer (`components.<Name>`, `semantics`, `sharedTokens`, `primitives`). The per-component `themeOverride` prop still accepts the component's own token map in object form or as a `(componentTheme) => ({...})` function — same shape as before, just with the v2 token names.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace this with:

What changed:

  • Theme overrides: in v11.7 InstUISettingsProvider's theme prop only accepts a full theme object. For v11.7 or later use the new themeOverride prop
  • token names/values: Lots of components had their theme tokens changed -- removed, added or renamed. Check the rest of this guide for the full list of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants