feat(ui-themes,ui-alerts): Test PR on how theme freezing works#2519
Closed
feat(ui-themes,ui-alerts): Test PR on how theme freezing works#2519
Conversation
note: its not complete, the WithStyleProps still has wrong types in most v2 components
…ides and add freeze functionlionality to old components
HerrTopi
requested review from
ToMESSKa,
balzss,
git-nandor,
joyenjoyer and
matyasf
|
matyasf
changed the title
matyasf
requested changes
Apr 20, 2026
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
just 2 small improvements, overall I like the documentation a lot!
Comment on lines
+25
to
+26
| // Frozen — uses the bundled v11_7 theme snapshot | ||
| @withStyle(generateStyle, null, frozenThemes) |
Collaborator
There was a problem hiding this comment.
I would add the import statement here, so the example is more clear
Collaborator
There was a problem hiding this comment.
Also I'd add how it works with useStyle
HerrTopi
force-pushed
the
fix-theme-overrides
branch
2 times, most recently
from
6623b92 to
e0c9869
Compare
Contributor
Author
|
Did its job, tested the already merged feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A temp pr, demonstrates how theme freezing works. This will be discarded when its parent will be merged in
check /v11_7/frozen-themes and the parent pr for context