Conversation
|
950ab9d to
c9f2d9e
Compare
de441d5 to
253a38d
Compare
| {...(interaction === 'enabled' && | ||
| !isEditable && { | ||
| themeOverride: (componentTheme) => ({ | ||
| //@ts-expect-error TODO-theme-types |
There was a problem hiding this comment.
This is the only change here, dont know why this file was reformatted
253a38d to
6c7faa5
Compare
There was a problem hiding this comment.
In the props.ts for Pagination and Table (and subcomponents) I see WithStyleProps<null, instead of WithStyleProps<ReturnType<NewComponentTypes['XXX']. Is that supposed to be like that?
Also for these components, the the themeOverride form ( e.g. <Avatar themeOverride={{borderColor: 'red'}}>aa) gives some TS error. I see that these use themeOverride?: ThemeOverrideValue where other components use WithStyleProps<ReturnType<NewComponentTypes['XXX']
- AiInformation
- DataPermissionLevels
- NutritionFacts
- Avatar
- FormFieldLayout
- NumberInput
- RadioInput
- Spinner
- TextArea
5475750 to
89b2370
Compare
Only if the component has no theme (=
I've fixed these too, |
89b2370 to
ab54902
Compare
ab54902 to
db78998
Compare
themeOverrideprop. Until now it was using theme types from the old engine.TextInput/v2/theme.ts, it was unusedTo test:
Check if theme overrides are typed correctly for v1 and v2 components, e.g.