chore: respected config precedence for agent-provided secrets#2547
Merged
Conversation
42 tasks
aryamohanan
force-pushed
the
chore-config-secret-agent
branch
from
d541429 to
a735db6
Compare
kirrg001
reviewed
May 13, 2026
kirrg001
approved these changes
May 13, 2026
Co-authored-by: kirrg001 <katharina.irrgang@ibm.com>
|
aryamohanan
added a commit
that referenced
this pull request
May 14, 2026
--------- Co-authored-by: kirrg001 <katharina.irrgang@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #2432 (comment)
Previously, agent-provided secrets configuration was directly applied via secrets.setMatcher(), bypassing the configuration precedence system. This meant agent config would override user-provided config (ENV vars
or in-code config), violating the intended precedence order: ENV > INCODE > AGENT > DEFAULT
The fix follows the established activate pattern used by other modules