Protect skill projections from foreign collisions#667
Draft
tomvaillant wants to merge 1 commit into
Draft
Conversation
tomvaillant
requested a deployment
to
inkeep-oss-sync
July 17, 2026 15:43 — with
GitHub Actions
Waiting
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prevents OpenKnowledge from silently deleting a user- or installer-owned skill when a same-name projection is installed. Preflighting all requested targets also prevents a partial multi-editor projection when one target conflicts.
Validation
pnpm --filter @inkeep/open-knowledge-server typecheckpnpm --filter @inkeep/open-knowledge-server exec vitest run skill-projection.test.ts --pool=forks --maxWorkers=1 --no-file-parallelism --reporter=verbosepnpm exec biome check packages/server/src/skill-projection.ts packages/server/src/skill-projection.test.ts .changeset/safe-skill-projections.md --error-on-warnings