Skip to content

Protect skill projections from foreign collisions#667

Draft
tomvaillant wants to merge 1 commit into
inkeep:mainfrom
tomvaillant:agent/safe-skill-projections
Draft

Protect skill projections from foreign collisions#667
tomvaillant wants to merge 1 commit into
inkeep:mainfrom
tomvaillant:agent/safe-skill-projections

Conversation

@tomvaillant

Copy link
Copy Markdown

Summary

  • preflight every project skill projection before writing any editor target
  • preserve exact existing links idempotently
  • refuse foreign files, directories, dangling links, and links to another source without modifying them

This prevents OpenKnowledge from silently deleting a user- or installer-owned skill when a same-name projection is installed. Preflighting all requested targets also prevents a partial multi-editor projection when one target conflicts.

Validation

  • pnpm --filter @inkeep/open-knowledge-server typecheck
  • pnpm --filter @inkeep/open-knowledge-server exec vitest run skill-projection.test.ts --pool=forks --maxWorkers=1 --no-file-parallelism --reporter=verbose
  • pnpm exec biome check packages/server/src/skill-projection.ts packages/server/src/skill-projection.test.ts .changeset/safe-skill-projections.md --error-on-warnings

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants