fix: update chronograf(alpine) to copy only binaries from tarball.#877
Open
karel-rehor wants to merge 2 commits into
Open
fix: update chronograf(alpine) to copy only binaries from tarball.#877karel-rehor wants to merge 2 commits into
karel-rehor wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the broken chronograf:1.11.x-alpine image startup by avoiding an incorrect copy of the full FHS-style tarball tree into /usr/bin, and instead copying only the Chronograf binaries into the expected location.
Changes:
- Update the Alpine 1.11 Dockerfile to copy only
usr/bin/*from the extracted tarball into/usr/bin, restoring the expected binary paths. - Preserve the prior image’s internal binary layout (consistent with the older
-statictarball behavior) while using the non-static tarball for 1.11.2.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
RE: additional QA and testing Just to be sure I tried the non-alpine (i.e. standard debian) chronograf image this morning. It appears to be OK Additionally, I tried passing CLI arguments to the locally built alpine chronograf image. This also appears to be OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #865 and #866
Since static tarballs are not available for the 1.11.2 release, copy into the docker image only the required binaries. This should preserve the same internal file structure found in the 1.10.9 release.