Skip to content

Lay foundation for namedisl + add set-likes and operations between them#5

Open
a-alveyblanc wants to merge 39 commits into
inducer:mainfrom
a-alveyblanc:initial-functionality
Open

Lay foundation for namedisl + add set-likes and operations between them#5
a-alveyblanc wants to merge 39 commits into
inducer:mainfrom
a-alveyblanc:initial-functionality

Conversation

@a-alveyblanc
Copy link
Copy Markdown
Contributor

  • Adds necessary pieces for named ISL object representation (base classes, types, utilities)
  • Adds representation for set-likes (Sets, Maps, BasicSets, BasicMaps)
  • Adds minimal set of operations between set-likes for use with loopy

Replaces #2

Comment thread namedisl/__init__.py Outdated
Comment thread namedisl/__init__.py Outdated
Comment thread namedisl/__init__.py Outdated
all_names += sorted(all_inp_names)
all_names += sorted(all_param_names)

name_to_dim: NameToDim = {}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dict comprehension

Comment thread namedisl/__init__.py Outdated
return constantdict(name_to_dim), constantdict(dt_to_names)


def _align_obj(
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align wants a chunker!

Comment thread namedisl/__init__.py Outdated
_name_to_dim: NameToDim

# used to reconstruct ISL object
_dimtype_to_names: DimTypeToNames
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make reconstruction (completely) generic.

Comment thread namedisl/__init__.py Outdated
@a-alveyblanc
Copy link
Copy Markdown
Contributor Author

Tests are finally passing. I think this is ready for (automated?) review. Foundation was handwritten, i.e. basic functionality in NamedIslObject and subclasses. Additional functionality was written by Codex as needed during development of inducer/loopy#970.

All commits can be squashed into a single commit.

@a-alveyblanc a-alveyblanc marked this pull request as ready for review May 21, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants