fix: improve DraftMap.{entries,values}() compatibility#1228
Open
mrcljx wants to merge 1 commit intoimmerjs:mainfrom
Open
fix: improve DraftMap.{entries,values}() compatibility#1228mrcljx wants to merge 1 commit intoimmerjs:mainfrom
mrcljx wants to merge 1 commit intoimmerjs:mainfrom
Conversation
mrcljx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed two issues with
draftMap.entries()(andvalues()):[Symbol.iterator]()but instead returns a new iterator instance (starting from the beginning again).This PR addresses them both while not adding a hard dependency on ES2025 features.