fix(napari): cycle glasbey colours via CyclicLabelColormap#42
Merged
Conversation
Passing the raw glasbey palette list to add_labels made napari map large label IDs past the end of the palette, so every cell rendered one flat colour (green). Wrap the palette in a CyclicLabelColormap so each label value cycles through a distinct colour. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Labels rendered as one flat colour (all green). Passing the raw
glasbey.create_palette(...)list toadd_labels(colormap=...)makes napari map large label IDs past the end of the palette.Fix
Build the glasbey palette, convert to RGBA, and wrap it in a
napari.utils.colormaps.CyclicLabelColormap— each label value now cycles through a distinct glasbey colour. (Restores the working mechanism from before the gallery-style refactor, but keeps the glasbey package.)🤖 Generated with Claude Code