Skip to content

Update factory method Java API links#3539

Open
arnabnandy7 wants to merge 2 commits into
iluwatar:masterfrom
arnabnandy7:fix/hartsel-heller
Open

Update factory method Java API links#3539
arnabnandy7 wants to merge 2 commits into
iluwatar:masterfrom
arnabnandy7:fix/hartsel-heller

Conversation

@arnabnandy7

Copy link
Copy Markdown

What does this PR do?

Updates the Factory Method README to replace outdated Java 8 API documentation links with Java 21 links and removes the obsolete javax.xml.bind.JAXBContext example.

Fixes #3368

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

PR Summary

Replaced outdated Java 8 API docs with Java 21 equivalents in the Factory Method README and removed the obsolete javax.xml.bind.JAXBContext example. Aligns documentation with newer JDK versions and fixes #3368.

Changes

File Summary
factory-method/README.md Updated Java API reference links from Java 8 to Java 21, replacing links for Calendar, ResourceBundle, NumberFormat, Charset, URLStreamHandlerFactory, and EnumSet. Removed the obsolete javax.xml.bind.JAXBContext example.

autogenerated by presubmit.ai

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • d962ecf: Update factory method Java API links

Signed-off-by: Arnab Nandy arnab_nandy7@yahoo.com

Files Processed (1)
  • factory-method/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (6)
  • factory-method/README.md [106-106]

    readability: "Inconsistent link syntax in README"

  • factory-method/README.md [107-107]

    readability: "Inconsistent link syntax in README"

  • factory-method/README.md [108-108]

    readability: "Inconsistent link syntax in README"

  • factory-method/README.md [109-109]

    readability: "Inconsistent link syntax in README"

  • factory-method/README.md [110-110]

    readability: "Inconsistent link syntax in README"

  • factory-method/README.md [111-111]

    readability: "Inconsistent link syntax in README"

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.23%. Comparing base (74d2dbe) to head (fb5ea6c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3539      +/-   ##
============================================
- Coverage     83.24%   83.23%   -0.01%     
- Complexity     4025     4028       +3     
============================================
  Files          1060     1060              
  Lines         14246    14246              
  Branches        686      686              
============================================
- Hits          11859    11858       -1     
- Misses         2100     2104       +4     
+ Partials        287      284       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)

Signed-off-by: Arnab Nandy arnab_nandy7@yahoo.com

Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hartsel heller bug

1 participant