Add Phase 3 PR B: covariates, trends, and extensions for dCDH#302

Merged

igerber merged 17 commits intomainfrom

dcdh-phase3b-covariates-trends

Apr 14, 2026

Commits on Apr 13, 2026

Add Phase 3 PR B: covariates, trends, and extensions for dCDH

igerber
and
claude
committed
Address AI review P1/P2 findings for Phase 3 PR B

igerber
and
claude
committed
Fix CI review Round 1: NaN-consistency, overall surface, rank_deficient_action

igerber
and
claude
committed
Fix CI review Round 2: NaN overall for trends, reject controls+heterogeneity

igerber
and
claude
committed
Fix CI review Round 3: validation guards for het/design2 interactions

igerber
and
claude
committed
Fix CI review Round 4: add intercepts to OLS regressions, NaN guard

igerber
and
claude
committed
Fix CI review Round 5: partial theta_hat, coarser-than-group, het docs

igerber
and
claude
committed
Fix CI review Round 6: thread set_ids into placebos, small-sample guard

igerber
and
claude
committed
Fix CI review Round 7: failed DID^X strata excluded, event study labels

igerber
and
claude
committed
Fix CI review Round 8: exclude failed DID^X strata from N_mat, fix labels

igerber
and
claude
committed
Fix CI review Round 9: suppress normalized_effects under trends, Inf guard

igerber
and
claude
committed
Fix CI review Round 10: NaN set validation, design2 raw Y, controls=[]

igerber
and
claude
committed
Fix CI review Round 11: document Design-2 raw-outcome contract

igerber
and
claude
committed
Fix CI review Round 12: document Assumption 14 support-trimming behavior

igerber
and
claude
committed
Fix CI review Round 13: per-period path uses raw Y under trends_linear

igerber
and
claude
committed
Address green review P3s: return type, design2 to_dataframe, docstrings

igerber
and
claude
committed
Update ROADMAP: mark 3i parity tests as shipped

igerber
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Phase 3 PR B: covariates, trends, and extensions for dCDH#302

Add Phase 3 PR B: covariates, trends, and extensions for dCDH#302
igerber merged 17 commits intomainfrom
dcdh-phase3b-covariates-trends

Commits on Apr 13, 2026

Add Phase 3 PR B: covariates, trends, and extensions for dCDH

Address AI review P1/P2 findings for Phase 3 PR B

Fix CI review Round 1: NaN-consistency, overall surface, rank_deficient_action

Fix CI review Round 2: NaN overall for trends, reject controls+heterogeneity

Fix CI review Round 3: validation guards for het/design2 interactions

Fix CI review Round 4: add intercepts to OLS regressions, NaN guard

Fix CI review Round 5: partial theta_hat, coarser-than-group, het docs

Fix CI review Round 6: thread set_ids into placebos, small-sample guard

Fix CI review Round 7: failed DID^X strata excluded, event study labels

Fix CI review Round 8: exclude failed DID^X strata from N_mat, fix labels

Fix CI review Round 9: suppress normalized_effects under trends, Inf guard

Fix CI review Round 10: NaN set validation, design2 raw Y, controls=[]

Fix CI review Round 11: document Design-2 raw-outcome contract

Fix CI review Round 12: document Assumption 14 support-trimming behavior

Fix CI review Round 13: per-period path uses raw Y under trends_linear

Address green review P3s: return type, design2 to_dataframe, docstrings

Update ROADMAP: mark 3i parity tests as shipped