fix: high concurrency issue with 503 context closure#165
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent browser context closures from disrupting in-flight requests under high concurrency by deferring context pool removals until a given account’s active request message queues have drained.
Changes:
- Wire
RequestHandler.isSystemBusyintoBrowserManagervia a provider callback to avoid rebalancing during busy periods. - Track active message-queue counts per auth index and emit an
authQueuesDrainedevent when an account’s queues reach zero. - Add “defer context close until idle” logic in
BrowserManagerfor pool pre-cleanup and rebalance, including cancel/flush of pending closures.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/core/ProxyServerSystem.js | Connects RequestHandler.isSystemBusy into BrowserManager to skip rebalance when busy. |
| src/core/ConnectionRegistry.js | Adds per-auth queue counting + emits authQueuesDrained when queues drain. |
| src/core/BrowserManager.js | Defers context closures until queues drain; cancels/flushes pending closures; adjusts pool occupancy check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.