Skip to content

Make dbcp2 testOnBorrow configurable #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suddendust merged 2 commits into from
Jun 29, 2026
Merged

Make dbcp2 testOnBorrow configurable #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93f42a8
Make dbcp2 testOnBorrow configurable
suddendust Jun 28, 2026
25b3f59
Merge branch 'main' into dbcp2_testOnBorrowConfig
suddendust Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...re/src/main/java/org/hypertrace/core/documentstore/model/config/ConnectionPoolConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,7 @@ public class ConnectionPoolConfig {

// Time duration to wait for surrendering an idle connection back to the pool
@NonNull @Builder.Default Duration connectionSurrenderTimeout = Duration.ofMinutes(5);

// Whether to validate connections when borrowing from the pool
@NonNull @Builder.Default Boolean testOnBorrow = true;
}
6 changes: 4 additions & 2 deletions ...tore/src/main/java/org/hypertrace/core/documentstore/postgres/PostgresConnectionPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,16 @@ private void setPoolProperties(
connectionPool.setMinIdle(getIdleCount(poolConfig.minIdlePercent(), maxConnections));
connectionPool.setBlockWhenExhausted(true);
connectionPool.setMaxWaitMillis(poolConfig.connectionAccessTimeout().toMillis());
connectionPool.setTestOnBorrow(poolConfig.testOnBorrow());
connectionPool.setAbandonedConfig(abandonedConfig);
log.debug(
"Postgres connection pool properties - maxTotal: {}, maxIdle: {}, minIdle: {}, maxWaitMillis: {}, connectionSurrenderTimeout: {}",
"Postgres connection pool properties - maxTotal: {}, maxIdle: {}, minIdle: {}, maxWaitMillis: {}, connectionSurrenderTimeout: {}, testOnBorrow: {}",
connectionPool.getMaxTotal(),
connectionPool.getMaxIdle(),
connectionPool.getMinIdle(),
connectionPool.getMaxWaitMillis(),
poolConfig.connectionSurrenderTimeout());
poolConfig.connectionSurrenderTimeout(),
poolConfig.testOnBorrow());
}

private void setFactoryProperties(
Expand Down
Loading