Open
Conversation
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
perf_kvm_support
branch
from
434a215 to
dd7ed8f
Compare
dblnz
reviewed
Mar 3, 2026
dblnz
left a comment
dblnz
left a comment
There was a problem hiding this comment.
LGTM! Just a few comments and questions.
| } | ||
|
|
||
| // Check perf_event_paranoid | ||
| if let Ok(val) = fs::read_to_string("/proc/sys/kernel/perf_event_paranoid") |
| /// Build the common `perf kvm` argument prefix used by both record and report. | ||
| fn perf_kvm_args(args: &PerfArgs, kallsyms: &Path) -> Vec<OsString> { | ||
| let mut perf_args: Vec<OsString> = vec!["kvm".into()]; | ||
| if args.host { |
There was a problem hiding this comment.
If you don't provide --guest or --host it knows to only perf the guest?
| /// | ||
| /// The iterator should start with the subcommand name ("perf"), which | ||
| /// clap consumes as the binary name (argv\[0\]). | ||
| pub fn run(args: impl Iterator<Item = OsString>) -> Result<()> { |
There was a problem hiding this comment.
Have you tried stripping the debug symbols from the binary loaded in the guest, but provide the correct symbols to perf?
This would show a "realistic" load time for the hyperlight guest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a simple wrapper around
perf kvmwhich setups necessary things for getting function name resolution in the guets