Fix model offloading and training tests + prevent examples timeout#14091
Open
GiGiKoneti wants to merge 2 commits into
Open
Fix model offloading and training tests + prevent examples timeout#14091GiGiKoneti wants to merge 2 commits into
GiGiKoneti wants to merge 2 commits into
Conversation
sayakpaul
reviewed
Jun 30, 2026
f1b7e44 to
5c98abf
Compare
sayakpaul
reviewed
Jul 1, 2026
71f7b15 to
f16aa73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes three pre-existing bugs in model offloading, training tests, and example test runs that were causing CI failures:
AutoencoderVidTok return format mismatch:
AutoencoderVidTok.forwardto return(dec,)whenreturn_dict=False, aligning it with the standard VAE return contract in Diffusers.test_outputs_equivalencesince the outputs match correctly now.AutoencoderDC mixed precision skip:
try-exceptblock to catchRuntimeError: "GET was unable to find an engine to execute this computation"and callpytest.skipwhen cuDNN cannot find matching computation engine configs.Examples timeout and distributed launch mitigation:
run_commandinexamples/test_examples_utils.pyto usesubprocess.runwith a configurabletimeoutparameter (default 300s) to prevent tests from hanging indefinitely.--num_processes 1 --num_machines 1toExamplesTestsAcceleratelaunch arguments to prevent distributed launch deadlocks on single-device/CPU CI runners.Fixes #14090
Before submitting
.ai/review-rules.md?Who can review?
@sayakpaul @DN6 @pcuenca