Route SanaTransformer2DModel.forward by time-embed type, not by guidance presence#13741
Open
Ricardo-M-L wants to merge 1 commit into
Open
Route SanaTransformer2DModel.forward by time-embed type, not by guidance presence#13741Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
…nce presence When SanaTransformer2DModel was built with guidance_embeds=True, the forward pass routed on `guidance is not None`. Pipelines that do not thread guidance through (SanaPipeline, SanaPAGPipeline) therefore fell into the `batch_size` branch and crashed with `TypeError: SanaCombinedTimestepGuidanceEmbeddings.forward() got an unexpected keyword argument 'batch_size'` (see huggingface#12540). Dispatch on `isinstance(self.time_embed, SanaCombinedTimestepGuidanceEmbeddings)` instead: the embedder type is what dictates the call signature. If the model was configured with guidance embeddings but the pipeline omits guidance, raise a clear ValueError naming the misconfiguration instead of surfacing a confusing kwargs error from the embedder. Fixes huggingface#12540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #12540.
When `SanaTransformer2DModel` is built with `guidance_embeds=True`, the forward pass routed on `guidance is not None`. Pipelines that do not thread guidance through (`SanaPipeline`, `SanaPAGPipeline`) therefore fell into the `batch_size` branch and crashed with:
```
TypeError: SanaCombinedTimestepGuidanceEmbeddings.forward() got an
unexpected keyword argument 'batch_size'
```
Fix
Dispatch on `isinstance(self.time_embed, SanaCombinedTimestepGuidanceEmbeddings)` instead — the embedder type is what dictates the call signature. If the model was configured with guidance embeddings but the pipeline omits guidance, raise a clear `ValueError` naming the misconfiguration instead of surfacing a confusing kwargs error from the embedder.
13 LOC, 1 file (`sana_transformer.py`). Unblocks Sana checkpoints that were trained with the guidance-embedding variant when used through the non-guidance pipelines.