Use defaultdict for _SET_ADAPTER_SCALE_FN_MAPPING#13320
Merged
sayakpaul merged 4 commits intohuggingface:mainfrom Mar 24, 2026
Merged
Use defaultdict for _SET_ADAPTER_SCALE_FN_MAPPING#13320sayakpaul merged 4 commits intohuggingface:mainfrom
sayakpaul merged 4 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
@sayakpaul some tests crashed, is this ok? is this related to proposed change? |
Member
|
Those are unrelated. Will merge after another round of CI. |
Member
|
(Fixing the CUDA test failures in #13323) |
Member
|
Failing tests are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently everyone patches
_SET_ADAPTER_SCALE_FN_MAPPINGwhen training their models with pefthttps://github.com/search?q=_SET_ADAPTER_SCALE_FN_MAPPING&type=code
Common patching practice looks like:
And as result every few months people modify file

peft.pyto add their own model:The reason for this is lack of default behavior for
_SET_ADAPTER_SCALE_FN_MAPPING.This pr proposes to replace
_SET_ADAPTER_SCALE_FN_MAPPINGwithdefaultdict. It will simplify adding new models to diffusers as well as training and inference models with peft.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
@sayakpaul, probably you can review this pr. Thanks!