Modular[add more tests] #13013
Open
Modular[add more tests] #13013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
Author
|
will need to adjust conflicts and fix more stuff after this #13078 and #13063 feel free to push directly into this PR too if you see anything you want to change |
added 2 commits
February 5, 2026 09:05
sayakpaul
reviewed
Feb 12, 2026
Comment on lines
+144
to
+146
| def test_loading_from_default_repo(self): | ||
| if self.default_repo_id is None: | ||
| return |
Member
There was a problem hiding this comment.
Suggested change
| def test_loading_from_default_repo(self): | |
| if self.default_repo_id is None: | |
| return | |
| def test_loading_from_default_repo(self): | |
| if self.default_repo_id is None: | |
| pytest.mark.skip("The underlying test class doesn't implement `default_repo_id`, skipping test.") |
Comment on lines
+170
to
+171
| # a hack to workaround the fact the default pipeline properties are often incorrect for testing cases, | ||
| # #e.g. vae_scale_factor is ususally not 8 because vae is configured to be smaller for testing |
Member
There was a problem hiding this comment.
Is this something because of how defaults are set? I think we should fix this.
| decode_inputs = filter_inputs(decode_available, decoder_node.blocks.input_names) | ||
| modular_output = decoder_node(**decode_inputs).images | ||
|
|
||
| assert modular_output.shape == standard_output.shape, ( |
Member
There was a problem hiding this comment.
Should we also add a check for the outputs? The outputs should also match right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add two more test:
promptshould be a required input for most pipelines