feat: implement apply_lora_scale to remove boilerplate.#12994
Merged
feat: implement apply_lora_scale to remove boilerplate.#12994
Conversation
Member
Author
|
@DN6 would love to know your thoughts! |
sayakpaul
commented
Jan 19, 2026
|
|
||
| from ...configuration_utils import ConfigMixin, register_to_config | ||
| from ...loaders import FluxTransformer2DLoadersMixin, FromOriginalModelMixin, PeftAdapterMixin | ||
| from ...utils import USE_PEFT_BACKEND, logging, scale_lora_layers, unscale_lora_layers |
Member
Author
There was a problem hiding this comment.
This yields 21 LoC deletions. We have this pattern in about 32 files. So, this amounts for a 672 deletions. Not bad, IMO.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
DN6
reviewed
Jan 27, 2026
|
|
||
| self.gradient_checkpointing = False | ||
|
|
||
| @apply_lora_scale("joint_attention_kwargs") |
Collaborator
There was a problem hiding this comment.
Nice! 👍🏽 Design looks good to me.
Member
Author
|
@DN6 a gentle ping |
DN6
reviewed
Feb 13, 2026
Collaborator
DN6
left a comment
There was a problem hiding this comment.
LGTM 👍🏽 Left a comment on a small check.
src/diffusers/utils/peft_utils.py
Outdated
| else: | ||
| if ( | ||
| not USE_PEFT_BACKEND | ||
| and attention_kwargs is not None |
Collaborator
There was a problem hiding this comment.
This path won't ever be accessed since to reach here attention_kwargs has to be None.
I think it's supposed to be
if attention_kwargs is not None:
attention_kwargs = attention_kwargs.copy()
kwargs[kwargs_name] = attention_kwargs
lora_scale = attention_kwargs.pop("scale", 1.0)
if not USE_PEFT_BACKEND and lora_scale != 1.0:
logger.warning(
f"Passing `scale` via `{kwargs_name}` when not using the PEFT backend is ineffective."
)
Member
Author
|
Merging as discussed with Dhruv. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, we have this pattern throughout the modeling implementations:
IMO, this is not pretty and should possibly be minimized for a clean and self-contained implementation of the
forward().Hence, this PR introduces a decorator
apply_lora_scalethat can be used to decorate the forward method of a model supporting LoRA. I think this will help us reduce a bunch of boilerplate code.For keeping the PR simple, I have only applied the decorator to
src/diffusers/models/transformers/transformer_flux.pyThe LoRA tests for it are passing, indicating this direction might be a nice one.