feat: async table loads + database-scoped results/query runs#84
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Reviewed. database_id/X-Database-Id is threaded consistently through the generated APIs, Arrow path, client/resource wrappers, and the query auto-follow path; all internal callers, the example, docs, and CHANGELOG are updated; and the header-vs-body fallback is covered by regression tests. No blocking issues.
zfarrell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www.hotdata.dev/pull/254
Also completes the regen by hand: results and query runs are now scoped to a database via the required
X-Database-Idheader, so the ergonomic layer (client.rs,resources.rs,arrow.rs,query.rs) threads adatabase_idthrough the results/query-run wrappers andquery()'s truncation auto-follow. Without this the crate does not compile against the regenerated signatures. Fixes theX-Database-Id header is requirederrors onresults list/queries list.