fix: publish Node-compatible package entrypoints#1622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #1621 by making the published HyperFrames packages importable from plain Node package consumers instead of exposing monorepo-only source entrypoints.
Why
The issue is real.
@hyperframes/engine@0.6.119publishes a manifest whosemain,types, andexportspoint atsrc/*.ts. A clean Node import therefore fails before user code runs because Node does not execute TypeScript package entrypoints.Fixing that manifest exposed the next layer of the same packaging root cause:
@hyperframes/corealready publishesdist, but its emitted ESM used extensionless relative imports such as./slideshow/parseSlideshowand dotted basenames such as./core.types. Those are not Node-resolvable in ESM either.How
publishConfigandfilesfor@hyperframes/engineso packed npm metadata points at compileddistentrypoints.tsccore build step that rewrites compiled relative ESM imports to Node-resolvable.jspaths, including dotted basenames likecore.types.@hyperframes/studioand@hyperframes/studio/tailwind-preset, while sharing the Tailwind preset with the app config to avoid drift.verify:packed-manifestsso it now packs every public workspace and rejects:workspace:refs in packed manifestssrc/*.tsTest plan
PATH=/home/ubuntu/.nvm/versions/node/v22.22.2/bin:$PATH bun run buildPATH=/home/ubuntu/.nvm/versions/node/v22.22.2/bin:$PATH bun run verify:packed-manifestspnpm packlocalcore,player,sdk,engine, andstudiotarballs, install them into an empty npm project, and import:@hyperframes/core@hyperframes/core/slideshow@hyperframes/engine@hyperframes/engine/alpha-blit@hyperframes/engine/shader-transitions@hyperframes/studio/tailwind-preset@hyperframes/studio