feat(studio): instantPatch fast path in runCommit#1613
Conversation
james-russo-rames-d-jusso
left a comment
james-russo-rames-d-jusso
left a comment
There was a problem hiding this comment.
Reviewed at decff5d6. Wiring is clean — applyPreviewSync extraction makes the path very testable, and the 6-case applyPreviewSync matrix in useGsapScriptCommits.test.tsx is exactly the right shape. Race-fix classification: this is a PREEMPT for the value-only-drag class (the reload doesn't merely run faster, it doesn't run at all when the patch lands) with a clean NARROW fallback to soft-reload (same shape as today). Good. Couple of structural concerns.
Concerns
-
Sibling-asymmetry —
findUnsafeMutationValuesdoesn't guard the fast path.runCommitcallsfindUnsafeMutationValues(mutation)before the POST and bails with a user-facing toast on unsafe values. The instantPatch fast path runspatchRuntimeTweenInPlace(iframe, selector, change)againstoptions.instantPatch.change— notmutation.patchSet/patchKeyframesre-checkNumber.isFinitefor their own inputs (so a raw NaN can't slip through), but if the mutation carries unsafe values, the earlyunsafeFields.length > 0path throws/returns BEFORE the patch is attempted — so we're fine on that side. The asymmetry to watch is the other direction:instantPatch.change.propsis sourced independently from the mutation (the caller constructs both), so a buggy caller can ship a clean mutation + a malformed patch. Today both come from the samenewX/newYlocals, so it's tight. Worth a code comment incommitStaticGsapPositionnoting the two must stay in lockstep (or, more durable: deriveinstantPatch.change.propsfrom the just-builtmutationobject so they can't drift). -
Fast-path can write to the wrong tween (channel-blind resolution). Repeating from my #1612 review since it's the place that matters:
resolveRuntimeTween(iframe, selector, "set")returns the first zero-duration tween matching the selector — no channel match.commitStaticGsapPosition's second commit attachesinstantPatch: { kind:"set", props:{x,y} }; if the live runtime has a separatetl.set("#el",{rotation})shape, the patch can land on the rotation tween and force-writex/ychannels there. Source file is correct, runtime is inconsistent until next full reload. Either tightenresolveRuntimeTween(prefer tween whosevarsalready carries one of the requested channels), or document fast-path as merged-set-only and gate the caller. -
Coalesced x/y intermediate commit silently swallows preview state.
commitStaticGsapPositiondoes{x: skipReload}then{y: softReload + instantPatch}. The intermediate POST writes the newxserver-side but leaves the live tween untouched (no patch, no reload). If the second POST fails server-side, the intermediateupdate-property xis now persisted but the user's visual feedback never reflected it — and theinstantPatchblock inrunCommitis downstream of the throw, so no patch fires either. The final-coalesce contract assumes the second commit always lands; worth a comment, or attachinginstantPatchto both commits withskipReloadon the first (the patch is idempotent, so re-applying is safe).
Nits
commitStaticGsapRotation's update-property carries{rotation: newRotation}in instantPatch but the source mutation is{property: "rotation", value: newRotation}. Same value, two shapes — minor mismatch readability. (nit)applyPreviewSyncdoc comment says "Onfalse— or when noinstantPatchis supplied — fall back to the existing soft/full reload." Once #1605 lands and drops the→ full reloadescalation, this sentence is stale. (nit, fixed by #1605)
What I didn't verify
- Whether
__player.seek(currentTime)after an in-placevarsmutation actually re-paints synchronously enough that the user perceives the patch as "instant" vs. "next frame" — there's a render flush in there I trusted the helper's test to assert correctly via theonSeekcallback model. - The
serializerRefordering across the coalesced x/y pair vs other simultaneous edits to the same file — the existinggsap-file:${file}per-file serializer should chain them, but I didn't trace the interleaving for a same-filecommitStaticGsapPositioncolliding with acommitStaticGsapRotation.
— Rames D Jusso
vanceingalls
left a comment
vanceingalls
left a comment
There was a problem hiding this comment.
Reviewed at decff5d6. Concur with @james-russo-rames-d-jusso — the wiring is clean, the applyPreviewSync extraction makes the path very testable, and the 6-case test matrix is exactly the right shape. But the channel-blind tween resolution from #1612 becomes user-reachable here, and the coalesced x/y intermediate-commit has a real failure mode worth pinning.
Verified at HEAD — instantPatch opt-in dispatch chain:
Every update-property site enumerated; only value-only (static set) commits opt in; structural branches correctly omit:
| Site | File:line | Mutation shape | Opt-in | Correct? |
|---|---|---|---|---|
commitStaticGsapPosition x (coalesced intermediate) |
gsapDragCommit.ts:354 |
update-property x, skipReload |
NO | ✓ |
commitStaticGsapPosition y (coalesced final) |
:359 |
update-property y, softReload |
YES {x,y} |
✓ (channel-blind risk, see below) |
commitStaticGsapPosition add (no existing) |
:374 |
add, softReload |
NO (structural) | ✓ |
commitStaticGsapRotation update |
:416 |
update-property rotation, softReload |
YES {rotation} |
✓ (channel-blind risk) |
commitStaticGsapRotation add |
:433 |
add, softReload |
NO (structural) | ✓ |
extendTweenAndAddKeyframe |
:142 |
extend keyframes | NO (structural) | ✓ |
commitKeyframedPosition |
:168 |
keyframe-edit | NO (PR body excludes) | ✓ |
commitFlatViaKeyframes (3 sites) |
:251, :282, :295 |
convert-to-keyframes/add-keyframe |
NO (structural) | ✓ |
commitGsapPositionFromDrag (3 sites) |
:594, :605, :616 |
structural | NO | ✓ |
useGsapPropertyDebounce.flushPendingPropertyEdit |
useGsapPropertyDebounce.ts:94 |
update-property, softReload |
NO | scope gap (below) |
Structural-branch silent-no-op risk within the drag commit graph: NONE. Every structural branch correctly omits instantPatch. Test at gsapDragCommit.test.ts:128 ("structural keyframe drag... sets no instantPatch") pins this.
Concur with @james-russo-rames-d-jusso's BLOCKERs:
-
Channel-blind runtime resolution makes the position fast-path land on the rotation
settween (or vice versa). Source-side writer discriminates (findPositionSetAnimation/findRotationSetAnimation);patchSetdoesn't. Position drag with{x,y}lands on a sibling rotationsettween → force-writesx/ychannels intovarsthat don't belong there. Source file correct, runtime inconsistent until next full reload (#1605 drops the full-reload escalation, so the inconsistency persists). Maps to band-aid pattern #2 + #4 as analyzed in my #1612 review; cheap fix is the channels-hint atresolveRuntimeTween. -
Coalesced x/y intermediate-commit silently swallows preview state on the first commit's failure.
commitStaticGsapPositiondoes{x: skipReload}then{y: softReload + instantPatch}. If the SECOND commit fails server-side, the persistedupdate-property xis stale on screen — theinstantPatchblock inrunCommitis downstream of the throw, no patch fires either. The final-coalesce contract assumes the second commit always lands. Either disclose explicitly OR attachinstantPatchto BOTH commits withskipReload: trueon the first (the patch is idempotent, so re-applying is safe). Band-aid pattern #3 (silent scope gap on coalescence contract). -
findUnsafeMutationValueslockstep gap.findUnsafeMutationValues(mutation)runs before POST; the instantPatch path runspatchRuntimeTweenInPlace(iframe, selector, change)againstoptions.instantPatch.change— independently sourced. Today both come from the samenewX/newYlocals so it's tight. Worth either (a) derivinginstantPatch.change.propsfrom the just-builtmutationobject so they can't drift, or (b) a code comment incommitStaticGsapPositionnoting the two must stay in lockstep. Durability-grade.
Net-new — drag-vs-panel asymmetry (NIT, scope-gap not band-aid):
useGsapPropertyDebounce.flushPendingPropertyEdit (panel-driven edits) produces a value-only update-property with softReload: true but does NOT carry instantPatch. Consistent with PR body's drag-scope framing, so not band-aid pattern #5 — but it leaves the property panel slower than drag for the same underlying operation. Worth either a follow-up PR or a sentence in the body acknowledging the panel path is unchanged this slice.
Concur with @james-russo-rames-d-jusso on nits:
applyPreviewSyncdoc comment "fall back to existing soft/full reload" is stale once #1605 drops the→ full reloadescalation. Update in this PR or #1605.commitStaticGsapRotation{rotation: newRotation}in instantPatch vs{property: "rotation", value: newRotation}in mutation — same value, two shapes — minor readability.
Verdict: BLOCK. Two hard request-changes from Rames I concur with; once channel-blindness + coalesced-pair failure mode close, this is clean wiring and the test matrix locks the contract. Race-fix classification PREEMPT (not NARROW) — strong shape.
Review by Via
A commit carrying an instantPatch option tries patchRuntimeTweenInPlace first; on success the preview updates in place with NO reload (instant), on false it falls back to the existing soft reload. Extracts the preview-sync tail into a testable applyPreviewSync helper. No behavior change when instantPatch is absent.
…tPatch
Static-element position and rotation set commits now attach instantPatch{selector,
change:{kind:set}} so the drag updates in place with no reload. Structural ops (new
tween add, delete-all, convert/split/materialize) and keyframe edits deliberately omit
it and keep the soft reload — keyframe instant-patch needs object-form keyframe support
in patchRuntimeTweenInPlace (deferred).
…tion, patch both coalesced commits, wire onAsyncFailure
- commitStaticGsapPosition/Rotation derive instantPatch.change.props from the actual
update-property mutation(s) sent (one source of truth → findUnsafeMutationValues-validated
values flow into the patch; can't drift).
- Coalesced x/y: the intermediate x commit also carries instantPatch{x}, the y commit {x,y},
so a second-POST failure still leaves the preview patched for what persisted.
- applyPreviewSync passes reloadPreview as onAsyncFailure (plugin-CDN load error → full reload);
per U4 the synchronous false still does NOT escalate.
- (channel disambiguation from #1612 verified end-to-end: {x,y}→position set, {rotation}→rotation set.)
miguel-heygen
force-pushed
the
feat/instant-patch-helper
branch
from
dc79a2a to
2a0df60
Compare
miguel-heygen
force-pushed
the
feat/instant-patch-wiring
branch
from
decff5d to
ff2be9d
Compare
|
Subsumed by #1605 (retargeted to main with the full stack) |
* chore(producer): shim __filename/__dirname in the CJS banner Bundled CJS deps like wawoff2 call __dirname; without the shim they throw "__dirname is not defined in ES module" at render time. Also ignore .zed/. * chore(producer): use a template literal for the CJS banner (review nit) * feat(core): add GSAP keyframe + motion-path source mutations Array-form keyframe removal in both the recast and acorn writers, plus update/add/remove-motion-path-point and add-motion-path. Exclude _auto and data from tween property-group classification. * fix(core): address #1554 review — data-exclusion test, split-fix doc, motion-path sentinel, parity blocks - Regression test for the `data` GSAP-key exclusion (parallel to _auto). - splitAnimationsInScript: documented that .fromTo()/.to() correctly stay out of the from-branch (only .from() reverts) and the <= boundary; added mid-flight straddle tests. - addMotionPathToScript failure path returns id: null (was empty-string sentinel); caller updated. - Parity blocks for addKeyframeToScript array-form + updateKeyframeInScript (mirroring removeKeyframeFromScript). Surfaced a latent acorn array-form partial-props merge bug — documented as it.skip with a ready assertion (acorn cutover follow-up). * feat(core): route motion-path mutations through studio-api + fix clip stamping Wire the new mutations into the file save route. Only authored clips suppress descendant stamping, so auto-stamped animated scenes can inline-expand. Hide in-flow timed clips with `display:none` only when they are LEAF clips (no nested timed clips). `display:none` on a container removes its whole subtree, hiding descendants that are still inside their own visibility window — e.g. an in-flow composition root whose effective window clamps to the timeline end would black out a child video that should still show (the hdr-hlg regression). Containers keep `visibility:hidden`, which a visible descendant can override; only leaves leave the flow, which is all the split-overlap case needs. * feat(core): strip legacy path-offset/rotation + drop obsolete studio lint rule A position or rotation add/set mutation makes the GSAP timeline the single source of truth for that channel, so any lingering --hf-studio-offset / --hf-studio-rotation CSS var must be cleared to avoid double-applying. stripStudioEditsFromTarget now clears both channels, and the add-strip fires for the position AND rotation property groups. Also removes the obsolete `gsap_studio_edit_blocked` lint rule: it warned that Studio cannot save drag/resize edits to elements in a registered timeline — the exact premise the single-source work inverts (the timeline is now the edit target). Removed the rule, its now-unused TIMELINE_REGISTRY_ASSIGN_PATTERN import, and its 5 tests. * fix(core): address #1555 review — complete hold-sync, invalidate clip cache, strip rotation channel - HOLD_SYNC_MUTATION_TYPES: add add-motion-path (load-bearing — addMotionPathToScript authors past t=0 → first-frame snap-to-(0,0) without the hold), update-meta, shift-positions, scale-positions, split-animations. (add stays out: flat tweens only, syncPositionHoldsBeforeKeyframes is a no-op for non-keyframed tweens.) - init.ts: timedClip in-flow/leaf WeakMaps now invalidate on clipTreeSignature change; visible/hidden branches both go through isTimedClipInFlow (was .get() by accident). - keyframesWriteRotation mirrors keyframesWritePosition so a rotation-only keyframe set strips the stale --hf-studio-rotation channel. * feat(studio): GSAP runtime read layer + shared helpers * fix(studio): address #1607 review — cold-parse vs fetch-error budgets, isZeroDurationSet, array-ease tests - useGsapAnimationFetchFallback: discriminate resolved/fetch-error/cold; only the cold (warm-but-zero) race gets the full ~600ms retry budget — a hard fetch error retries once. - Extract isZeroDurationSet (was !(duration>0) duplicated); rejects NaN, documents intent. - parsePercentageKeyframes: cite GSAP even-index spread; tests that a per-entry/interior ease is stripped without shifting the other keyframes' percentages. * feat(studio): GSAP drag/commit/bridge editing infra * fix(studio): address #1608 review — facade awaits commit, strict stale-parse guard, clearProps restore BLOCKER: useSafeGsapCommitMutation now RETURNS the (.catch-chained) commit promise and the commitMutation facade awaits it — so await session.commitMutation(...) resolves AFTER the server save, fixing both consumers (useEnableKeyframes + useGestureCommit's showToast/requestSeek/idle, which were firing before the save landed). SafeGsapCommitMutation return type widened void→Promise<void> (fire-and-forget consumers ignore it). - stale-parse guard uses hasNonHoldTweenForElement (a leftover hold set no longer counts as live). - commitFlatViaKeyframes snapshots dragged gsap values before clearProps + restores after seek, so a failed commit leaves the dropped pose, not a cleared element. * feat(studio): motion-path geometry + commit helpers * docs(studio): address #1609 review — document occlusion fade-in invariant, donut limit, nearestPointOnPath t-semantics * feat(studio): on-canvas motion-path overlay * fix(studio): address #1610 review — scope dblclick to pan-surface, kind-aware geometry guard, gate createMode, screen-space drag threshold * feat(studio): keyframes flag, gesture recording + timeline/selection refinements * fix(studio): address #1611 review — fetch-first keyframe path, gated hydration, dev-gated debug + gesture warn, per-group gesture tweens - useEnableKeyframes: parse current source first (null-vs-[] distinction) so a delete-all's empty parse isn't overridden by a stale selectedGsapAnimations cache. - useStudioUrlState: freeze the hydration effect's time dep once hydrated (was re-running every tick). - useGestureRecording: dev-gated console.warn when the live-preview runtime throws (was silent). - playerStore: gate window.__playerStore behind dev (guarded import.meta.env.DEV). - useGestureCommit: partition recorded keyframes by property group → one add-with-keyframes per group, so a mixed gesture no longer yields an untagged legacy tween. * feat(studio): single-source manual offset + rotation via the GSAP timeline Dragging or rotating an element writes into the GSAP timeline (the single source of truth) instead of a parallel --hf-studio-offset / --hf-studio-rotation CSS var: static elements commit a tl.set (idempotent on re-edit), tweened elements edit keyframes, and the live preview moves via gsap.set so what you see equals what is written and renders. Removes the dual-channel CSS-var/transform reconciliation behind the fling / disappear / runaway / double-stack / wrong-start bug class — for BOTH position and rotation (gesture base read from the gsap transform, gsap.set live preview, tl.set/ keyframe commit, dropped the handleDom*Commit CSS fallbacks). Subcompositions edit the same single-source way, which surfaced and fixes: - resolve a subcomp element's source file via the composition-id map (the runtime drops the source linkage when inlining the subcomposition); - a selected element's selection box AND motion path use basic visibility, not the occlusion heuristic (a backgroundless opacity-1 scene above it is not an opaque cover); - soft reload rebuilds ONLY the committed composition's timeline, leaving other compositions' timelines intact (no cross-composition revert); - read keyframes from the element's OWN composition timeline (scan all timelines, not the first unstable key); - delete-all uses a soft reload too, so editing no longer hard-reloads the iframe. * fix(studio): address #1567 review — drop drag-intercept flag, harden softReload onerror, tighten runtime ladder, per-group gestures - DROP STUDIO_GSAP_DRAG_INTERCEPT_ENABLED: single-source GSAP intercept is the only position/rotation channel; the false branch silently killed drag+rotate (and let GSAP elements into the keyframe-corrupting CSS path). Removed flag + dead branch + env def + tests. - gsapSoftReload: plugin onerror no longer fakes success — signals onAsyncFailure so the caller full-reloads; honors __hfMotionPathPluginLoading so a concurrent reload can't queue a dup script. - gsapDragCommit: resolveDragRuntime narrows the as-any ladder; a mid-seek throw logs + drops partial reads (no phantom identity) and re-applies the drag override in finally. - MotionPathOverlay: park-timer cleanup keyed on animId change. - useGestureCommit: partitionKeyframesByGroup wraps the add-with-keyframes sites (per #1611 review). * feat(studio): patchRuntimeTweenInPlace — update a tween's values in place Defensive runtime helper: locate the element's tween in window.__timelines via the shared resolveRuntimeTween scan, update its set/keyframe vars, invalidate, and re-seek the playhead — without re-running the whole composition. Returns false (caller falls back to soft reload) for any shape it can't safely patch (no tween, dynamic/computed keyframes, motionPath arc, channel mismatch, or any error). Foundation for instant, flicker-free manual edits. * fix(studio): address #1612 review — channel-aware set resolution + decline dynamic-expression patches - resolveRuntimeTween gains an optional channels[] hint; for kind:set it prefers the set whose vars carry one of the patched channels and never returns a disjoint-only set (e.g. won't write {x,y} into a co-located {rotation} set). patchRuntimeTweenInPlace derives channels from the props. - patchSet declines (returns false → soft reload) when overwriting a string/dynamic vars[ch], instead of silently dropping the computed expression. * feat(studio): instantPatch fast path in runCommit A commit carrying an instantPatch option tries patchRuntimeTweenInPlace first; on success the preview updates in place with NO reload (instant), on false it falls back to the existing soft reload. Extracts the preview-sync tail into a testable applyPreviewSync helper. No behavior change when instantPatch is absent. * feat(studio): route static position/rotation set drags through instantPatch Static-element position and rotation set commits now attach instantPatch{selector, change:{kind:set}} so the drag updates in place with no reload. Structural ops (new tween add, delete-all, convert/split/materialize) and keyframe edits deliberately omit it and keep the soft reload — keyframe instant-patch needs object-form keyframe support in patchRuntimeTweenInPlace (deferred). * fix(studio): address #1613 review — derive instantPatch from the mutation, patch both coalesced commits, wire onAsyncFailure - commitStaticGsapPosition/Rotation derive instantPatch.change.props from the actual update-property mutation(s) sent (one source of truth → findUnsafeMutationValues-validated values flow into the patch; can't drift). - Coalesced x/y: the intermediate x commit also carries instantPatch{x}, the y commit {x,y}, so a second-POST failure still leaves the preview patched for what persisted. - applyPreviewSync passes reloadPreview as onAsyncFailure (plugin-CDN load error → full reload); per U4 the synchronous false still does NOT escalate. - (channel disambiguation from #1612 verified end-to-end: {x,y}→position set, {rotation}→rotation set.) * feat(studio): no full iframe remount for soft-reloadable edits A softReload edit (and the SDK single-script refresh) no longer escalates to a full reloadPreview() iframe remount when applySoftReload returns false — the live gsap.set already shows the value, and a remount is the worst flash + re-inlines subcomps (reverting their keyframes). verifyTimelinesPopulated now checks the expected target keys the re-run registers, so a correct scoped re-run doesn't spuriously report empty. Full reload stays only for the structural (no-softReload) and ambiguous-script paths. * feat(studio): pre-load MotionPathPlugin so motion-path edits don't async-flash ensureMotionPathPluginLoaded() runs once at the preview iframe-load seam (NLELayout onIframeLoad), eagerly loading + registering MotionPathPlugin without killing the timeline. So when a user adds a motion path to a composition that didn't originally use one, the soft reload runs synchronously instead of taking the kill-then-await-CDN async path (the flash). Idempotent + defensive; the existing async fallback stays for genuine cold-start/CDN-failure. * fix(studio): don't re-save + reload when source editor syncs externally The SourceEditor's CodeMirror update listener fired onChange on ANY docChanged — including the programmatic dispatch that syncs external content (e.g. a manual-edit commit writing the source back into the open editor). That made the editor re-save the file and bump refreshKey, fully reloading the preview iframe on every drag/keyframe edit — defeating the in-place instant patch and causing the flash. Annotate the programmatic sync (ExternalSync) and skip onChange for it, so only real keystrokes save. * fix(core): inject MotionPathPlugin into preview when a composition uses motionPath A studio-created motion path writes a gsap motionPath tween into the single-source timeline, but the preview HTML only loaded gsap core — so the first render threw "Invalid property motionPath ... Missing plugin?". Detect motionPath usage and inject MotionPathPlugin right after the composition's gsap script, version-matched to it. * fix(studio): dedup __hfMotionPathPluginLoading type decl (restack artifact) * fix(studio): address #1605 review — distinguish soft-reload failure modes + observability, SourceEditor focus guard BLOCKER: applySoftReload now returns SoftReloadResult ('applied' | 'verify-failed' | 'cannot-soft-reload') instead of a bare bool. applyPreviewSync + sdkRefresh escalate to a full reloadPreview() on the PERMANENT 'cannot-soft-reload' (no gsap/rebind hook/scopable key/script, or sync re-run threw) — fixing the silent-stale-preview U4 dropped — but still suppress the TRANSIENT 'verify-failed' (live gsap.set is correct). Telemetry: gsap_soft_reload_outcome (origin/result/escalated) + gsap_instant_patch_fallback, so the U4 invariant is enforced, not asserted. - SourceEditor: skip the programmatic external-sync replace while the editor is focused, so an in-flight commit doesn't clobber the user's uncommitted keystrokes (ExternalSync kept for unfocused). - Verified ensureMotionPathPluginLoaded already guards __hfMotionPathPluginLoading (no double-append). * fix(core): align __clipTree and __clipManifest ids via stableClipId Timeline inline expansion was dead for nested children inside index.html: the tree keyed id-less elements by a synthetic __clip-N while the manifest keyed them null, so parent<->child never joined. Both now resolve identity through stableClipId (id || data-hf-id), which every generated element has. * fix(core): strip baked runtime + tag comp root in preview assembly Comps that ship a baked inline runtime were double-loaded (preview injects its own) and the baked copy failed to parse inline (Unexpected token '<'). Strip it in buildSubCompositionHtml + the disk-fallback preview path. Also tag the comp root with data-composition-file so the studio resolves a comp's top-level elements to the right source file instead of defaulting to index.html (which made the GSAP panel parse the wrong, multi-timeline file). * feat(studio): set motion-path destination from a toolbar toggle Replaces the double-click-on-canvas UX (which painted text over the preview) with a 'Set motion destination' toggle next to Snap/Grid, shown only when the selected element can take a path. While armed, one canvas press places the destination. Also removes the dead TimelinePropertyRows component. * fix(studio): center timeline keyframe diamonds on their percentage Dropped clampDiamondLeft, which forced boundary keyframes fully inside the clip so a 0% diamond sat half a diamond right of the 0% point. Each diamond's midpoint now sits exactly on its % (the clip is overflow-visible). * fix(studio): resize static elements via tl.set, not a single-stop keyframes tween Resizing an element with no size animation wrote keyframes:{ <playhead%>: {width,height} } — one mid-point stop GSAP can't interpolate, so it rendered NaN/0 dimensions at every other frame and the element vanished (worst off 0%). Added commitStaticGsapSize (mirrors commitStaticGsapPosition): a static resize now writes tl.set({width,height}), held at all frames; re-resizing updates it in place. * fix(studio): negative-cache failed media probes Only successful probes were cached, so CORS/404 cross-origin media was re-probed every rAF-driven timeline re-derive, flooding the console. Remember failed URLs and skip them. * fix(studio): type window.setTimeout handle as number ReturnType<typeof window.setTimeout> infers NodeJS.Timeout when @types/node is present and clashes with the DOM number the call returns. Type it number. * fix(studio): drag/resize disappearance, stale-ID duplicates, soft-reload clearProps - Fix soft-reload clearProps destroying element inline styles — save cssText, clear, restore, strip only transform - Fix resize no-op on re-resize: delete+add instead of two update-property - Route set tweens through static resize path (convertToKeyframes skips sets) - Re-fetch animation ID before drag commit to prevent stale-ID duplicates - Guard editDebugLog for Node test environments - Fix NLELayout setState-during-render (move reset to useEffect) - Stop SnapToolbar pointer events propagating to canvas deselect handler - Enable click-to-add waypoints on cubic motion paths - Add whole-path drag offset (Alt+drag shifts all keyframes together) - Add Canvas shortcuts section to ShortcutsPanel - Extract useMotionPathData + commitGsapPositionFromDrag (filesize compliance) - Delete dead code (getElementDepth, isElementVisibleInPreview, unused exports)
3 participants
Summary
This PR wires the value-only
instantPatchfast path into the GSAP commit pipeline. When a drag only changes the values of an existing tween (a staticsetof position or rotation),runCommitnow patches that one tween directly in the preview's runtime timeline in place — no composition re-run, no soft reload, no iframe remount — so the dragged element is correct on screen instantly. If the in-place patch can't be confidently applied, it falls back to the existing soft-reload (then full-reload) path, so behavior is never worse than today.The
patchRuntimeTweenInPlacehelper landed in #1612; this PR connects it tocommitMutation/runCommitand routes the static position/rotation drags through it. Structural and keyframe edits deliberately do not opt in.What's changed
gsapScriptCommitTypes.tsAdds optional
instantPatch?: { selector: string; change: RuntimeTweenChange }toCommitMutationOptions. The doc comment spells out the contract: when present,runCommitfirst tries the in-place patch; on success the reload is skipped entirely (panels still refresh via cache invalidation); when it can't apply, fall back to soft/full reload. Structural edits omit it.useGsapScriptCommits.tsrunCommitinto a new pure, exported helperapplyPreviewSync(iframe, result, options, reloadPreview)(no React → directly unit-testable).options.instantPatchis set, callpatchRuntimeTweenInPlace(iframe, selector, change); ontruereturn early (element already correct, no reload); onfalse/ noinstantPatch, fall through to the existing path (soft-reload whensoftReload && result.scriptText, escalating toreloadPreview()if the soft reload fails, else fullreloadPreview()).runCommitdelegates toapplyPreviewSync(...)instead of inlining the branch; the priorappliedbookkeeping is removed;onCacheInvalidate()still fires in every case. ImportspatchRuntimeTweenInPlace.gsapDragCommit.tsRuntimeTweenChangeand addsinstantPatch?to thecommitMutationcallback options inGsapDragCommitCallbacks.commitStaticGsapPosition— the final commit of the coalesced x/y pair (theupdate-propertyfory, carryingsoftReload: true) also attachesinstantPatch: { selector, change: { kind: "set", props: { x, y } } }(the full{x, y}so the runtimetl.setis patched in one shot). The intermediatexcommit staysskipReload, no patch.commitStaticGsapRotation— the value-only rotationupdate-propertycommit attachesinstantPatch: { selector, change: { kind: "set", props: { rotation } } }.settween, keyframe conversion) are untouched and carry noinstantPatch.Why
patchRuntimeTweenInPlacealready knew how to mutate a single runtime tween, but nothing in the commit pipeline used it — every drag commit went through a soft (or full) reload. For the most common interaction (dragging a layer to reposition/rotate, which only changes an existingset's values), that reload is wasted work and adds visible latency.instantPatchlets a commit declare "this is a value-only change to this tween — try patching it directly";runCommithonors that, giving instant feedback while keeping the source write + cache invalidation intact. Thepatch → soft reload → full reloadfallback means anything structural or ambiguous degrades gracefully to exactly today's behavior.Testing
useGsapScriptCommits.test.tsx(new) — mockspatchRuntimeTweenInPlace+applySoftReload.applyPreviewSync(pure): six cases covering the full matrix (instant succeeds → no reload; instant fails → soft; instant+soft fail → full; and the three no-instantPatchcases matching today).runCommit(full hook): instant succeeds → persists (one fetch) + records + invalidates + no reload; instant fails → persists + soft-reload fallback; no instantPatch → identical to today.gsapDragCommit.test.ts—commitStaticGsapPosition(intermediate x isskipReloadno patch; final y carriessoftReload+ full{x,y}patch; adding a new set is structural, no patch);commitStaticGsapRotation(update carries{rotation}patch; add is structural);commitGsapPositionFromDragkeyframe drag is structural (noinstantPatch).gsapRuntimeBridge.test.ts—tryGsapDragInterceptforwardsinstantPatch { kind:"set", x, y }on the final commit when updating an existing static set (x no patch, final y the full{x,y}).Stack
Part of the GSAP keyframe/motion-path stack:
#1553 → #1554 → #1555 → #1607 → #1608 → #1609 → #1610 → #1611 → #1567 → #1612 → #1613 → #1605. On #1612. Builds independently; combined diff byte-identical to the originally-reviewed work.