Skip to content

Specify default, minimum permissions for "Issue Trigger" workflow#8670

Open
t-will-gillis wants to merge 1 commit into
hackforla:gh-pagesfrom
t-will-gillis:rvw-permissions-issue-trigger-8336
Open

Specify default, minimum permissions for "Issue Trigger" workflow#8670
t-will-gillis wants to merge 1 commit into
hackforla:gh-pagesfrom
t-will-gillis:rvw-permissions-issue-trigger-8336

Conversation

@t-will-gillis
Copy link
Copy Markdown
Member

@t-will-gillis t-will-gillis commented May 31, 2026

Fixes #8336

What changes did you make?

  • Added default, workflow-level permissions to issue-trigger.yml

Why did you make the changes (we will use this info to test)?

  • We want to limit the default GITHUB_TOKEN permissions to the minimum required access for this workflow, following GitHub Actions security best practices.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Test logs

If you want to review this

  • See "Resources/Instructions" on Review Permissions for the "Issue Trigger" workflow #8336 to set up your environment
  • Additionally, on github-actions/trigger-issue/add-preliminary-comment/preliminary-update-comment.js, change line 69 to const isAdminOrMerge = true;
  • Whenever github-actions/utils/query-issue-info.js or github-actions/utils/mutate-issue-status.js runs, there will be an error. This can be addressed, but is probably more work than you need to do to review this. If you want to fix this, let me know and I can show you. Otherwise, ok to ignore it.

@github-actions github-actions Bot added role: back end/devOps Tasks for back-end developers Complexity: Large Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 5pt Can be done in 19-30 hours Lang: GHA GitHub Actions labels May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Large Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 5pt Can be done in 19-30 hours

Projects

Status: PR Needs review

Development

Successfully merging this pull request may close these issues.

Review Permissions for the "Issue Trigger" workflow

1 participant