Specify default, minimum permissions for "Issue Trigger" workflow#8670
Open
t-will-gillis wants to merge 1 commit into
Open
Specify default, minimum permissions for "Issue Trigger" workflow#8670t-will-gillis wants to merge 1 commit into
t-will-gillis wants to merge 1 commit into
Conversation
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8336
What changes did you make?
issue-trigger.ymlWhy did you make the changes (we will use this info to test)?
GITHUB_TOKENpermissions to the minimum required access for this workflow, following GitHub Actions security best practices.CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Test logs
If you want to review this
github-actions/trigger-issue/add-preliminary-comment/preliminary-update-comment.js, change line 69 toconst isAdminOrMerge = true;github-actions/utils/query-issue-info.jsorgithub-actions/utils/mutate-issue-status.jsruns, there will be an error. This can be addressed, but is probably more work than you need to do to review this. If you want to fix this, let me know and I can show you. Otherwise, ok to ignore it.