core: add average size and small frame percentage check for readable buffer#12904
Open
shivaspeaks wants to merge 8 commits into
Open
core: add average size and small frame percentage check for readable buffer#12904shivaspeaks wants to merge 8 commits into
shivaspeaks wants to merge 8 commits into
Conversation
kannanjgithub
approved these changes
Jul 13, 2026
| // mathematically equivalent to: percentage > 0.50 | ||
| boolean isHighPercentageSmall = (smallFrameCount * 2) > size; | ||
|
|
||
| if (isAvgSmall || isHighPercentageSmall) { |
Contributor
There was a problem hiding this comment.
Just inline the expressions so that it will skip evaluation of the 2nd argument to ||.
sauravzg
reviewed
Jul 13, 2026
| } | ||
| } | ||
|
|
||
| private static final int MAX_QUEUED_BUFFERS = 1000; |
Contributor
There was a problem hiding this comment.
Do we need some sort of load testing or data analysis to find optimal hyper params here? or maybe use the same values that other implementations use ?
Member
Author
There was a problem hiding this comment.
Not really sure on how to find the best constant here, it differs largely on usecases. Can we discuss this in the design? I don't have any plan for load testing right now but we can always tune it in the future if profiling dictates. My suggestion is to go with the current 1000 as it sounds reasonable.
shivaspeaks
force-pushed
the
prevent-heap-oom
branch
2 times, most recently
from
e2edacc to
d9d0c06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.