-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix map enum type in query parameters and enable skipped browser tests #6245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: johanbrandhorst <6604151+johanbrandhorst@users.noreply.github.com>
Co-authored-by: johanbrandhorst <6604151+johanbrandhorst@users.noreply.github.com>
johanbrandhorst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need to regenerate the protobuf files after changing the openapiv2 generator. Could you try following the instructions in CONTRIBUTING.md to regenerate the files?
I tried to regenerate the files but the buf.build remote server is unavailable from my environment (getting "Failure: the server hosted at that remote is unavailable"). The CI should be able to regenerate the files when it runs. The expected change after regeneration: The Would you be able to run Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Please try again, I updated the network settings |
Map parameters with enum values in query parameters were missing the
typeattribute in generated OpenAPI specs, causing swagger-client to serialize them as[object Object].OpenAPI Generator Fix
template.go: FixednestedQueryParamsto properly handle map value types:type: "string"(or"integer"withEnumsAsInts)Browser Tests
a_bit_of_everything_service.spec.js: Re-enabledCreateendpoint tests by excluding map values from request params (swagger-client v2 cannot serialize objects to query strings—fundamental library limitation)Unit Tests
TestMessageToQueryParametersWithMapEnumValuecovering:map<string, Enum>with string/integer representationmap<string, NestedMessage>(verified unsupported)All 10 browser tests now pass (previously 8 passing, 2 skipped).
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
buf.build/home/REDACTED/go/bin/buf buf generate -goversion go1.24.11 -symabis /tmp/go-build2748455656/b756/symabis -c=4 -nolocalimports -importcfg /tmp/go-build2748455656/b756/importcfg -pack -asmhdr rpc-�� XbeJq85uD 2QBb/-EzazWquSzRgithub.com/bufbuild/buf/private/gen/proto/go/buf/alpha/studio/v1alpha1(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.