Skip to content

Add PNG for NYC in conference-kit.zip, higher-res exports by default #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bignimbus wants to merge 1 commit into
base: source
Choose a base branch
from
+6 −2
Open

Add PNG for NYC in conference-kit.zip, higher-res exports by default #2394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified public/conference-kit/conference-kit.zip
View file
Open in desktop
Binary file not shown.
8 changes: 6 additions & 2 deletions scripts/render-conference-kit-banners.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@
* them into public/conference-kit/conference-kit.zip. Expects a dev/prod server to
* already be running on $URL (default http://localhost:3000) — invoke after
* `pnpm dev` is up, or against a `pnpm start` instance. Override SCALE for
* print-grade output (e.g. SCALE=6 → 3600×8472 ≈ 100 dpi at 850×2000 mm).
* print-grade output. SCALE=11 is the practical maximum: headless Chromium's
* compositor caps GPU textures at 16 384 px, and the banner height at SCALE=12
* (1412×12=16 944 px) exceeds that, causing partial renders. SCALE=11 gives
* 6 600×15 532 px ≈ 197 dpi at 850×2000 mm, which large-format print shops
* accept without complaint.
*
* Only the zip is written to public/. Loose PNGs land in a tmp dir and are
* cleaned up so the served directory stays minimal.
Expand All @@ -21,7 +25,7 @@ const exec = promisify(execFile)
const URL = process.env.URL ?? "http://localhost:3000"
const PAGE = `${URL}/conf/conference-kit/`
const PUBLIC_DIR = path.resolve(process.cwd(), "public/conference-kit")
const SCALE = Number(process.env.SCALE ?? 4)
const SCALE = Number(process.env.SCALE ?? 11)

type ColorScheme = "light" | "dark"

Expand Down
Loading