Skip to content

Comments

Rewards Eligibility Oracle testing#1289

Draft
RembrandtK wants to merge 4 commits intomainfrom
reo-testing
Draft

Rewards Eligibility Oracle testing#1289
RembrandtK wants to merge 4 commits intomainfrom
reo-testing

Conversation

@RembrandtK
Copy link
Contributor

Working branch for Rewards Eligibility Oracle testing and associated deployment changes.

- Add reo:enable, reo:disable, reo:status Hardhat tasks
- Improve bytecode change detection and proxy hash verification
- Allow deploy:status to run without deployer key
- Fix etherscan API key resolution from keystore and environment
- Add diagnostic scripts for bytecode and rocketh state inspection
- Update IRewardsManager interface ID
- Add baseline and REO-specific test plans
- Add self-service indexer test guide for eligibility verification
- Add Notion test tracker with CSV export for coordination
- Document local-network integration test coverage (32 tests)
- Organize support files into support/ subdirectory
- Remove obsolete planning docs and Notion raw exports
Functional summary of before/after reward behaviour changes between
the Horizon mainnet baseline and the issuance upgrade: activation
overview, reclaim system, view function semantics, and provenance.
@socket-security
Copy link

socket-security bot commented Feb 23, 2026

@socket-security
Copy link

socket-security bot commented Feb 23, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm @react-native/debugger-frontend is 96.0% likely obfuscated

Confidence: 0.96

Location: Package overview

From: pnpm-lock.yamlnpm/@react-native/debugger-frontend@0.81.4

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@react-native/debugger-frontend@0.81.4. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm buffer is 96.0% likely obfuscated

Confidence: 0.96

Location: Package overview

From: pnpm-lock.yamlnpm/@openzeppelin/hardhat-upgrades@1.28.0npm/@openzeppelin/foundry-upgrades@0.4.0npm/buffer@4.9.2

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/buffer@4.9.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Draft test plans covering issuance upgrade behavior changes beyond REO:
- SubgraphDenialTestPlan: 6 cycles, 18 tests for deny/undeny lifecycle,
  accumulator freeze, allocation-level deferral, reward recovery
- RewardsConditionsTestPlan: 7 cycles, 26 tests for reclaim system,
  below-minimum signal, zero allocated tokens, POI presentation paths,
  allocation resize/close, observability

Updated README with dependency tree and coverage summaries.
Added 44 new tests to NotionTracker.csv.
@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.95%. Comparing base (ada3155) to head (2ba0551).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1289   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files          46       46           
  Lines        2492     2492           
  Branches      746      746           
=======================================
  Hits         2167     2167           
  Misses        325      325           
Flag Coverage Δ
unittests 86.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant