Replaced AuthorizeAttribute check with ApiGroupAttribute in IsApiFrontAuthenticated() to determine API group membership.#688
Open
Taraweesh wants to merge 1 commit intograndnode:developfrom
Conversation
…tAuthenticated() to determine API group membership.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes frontend customer resolution in ApiAuthenticationService by identifying storefront API requests through the codebase’s v2 API-group metadata instead of relying on AuthorizeAttribute, which does not represent the affected frontend endpoints.
Changes:
- Replaced the frontend API detection logic in
IsApiFrontAuthenticated()to look forApiGroupAttributewith the v2 group name. - Added the shared-kernel imports needed to read API-group metadata and constants.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+66
to
+67
| var apiGroupAttr = endpoint.Metadata.GetOrderedMetadata<ApiGroupAttribute>(); | ||
| return apiGroupAttr.Any(attr => attr.GroupName == ApiConstants.ApiGroupNameV2); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced AuthorizeAttribute check with ApiGroupAttribute in IsApiFrontAuthenticated() to determine API group membership.#678