Skip to content

Test compound assignment order of eval#4606

Merged
sudonatalie merged 1 commit intogpuweb:mainfrom
sudonatalie:compound-eval-order
Feb 26, 2026
Merged

Test compound assignment order of eval#4606
sudonatalie merged 1 commit intogpuweb:mainfrom
sudonatalie:compound-eval-order

Conversation

@sudonatalie
Copy link
Contributor

Test that the lhs is evaluated before the rhs in a compound assignment statement.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@sudonatalie sudonatalie requested a review from jrprice February 26, 2026 16:29
@github-actions
Copy link

github-actions bot commented Feb 26, 2026

Results for build job (at 5873a23):

+webgpu:shader,execution,statement,compound:eval_order:* - 1 cases, 1 subcases (~1/case)
-TOTAL: 280592 cases, 2321591 subcases
+TOTAL: 280593 cases, 2321592 subcases

Test that the lhs is evaluated before the rhs in a compound assignment
statement.
@sudonatalie sudonatalie merged commit d213d4b into gpuweb:main Feb 26, 2026
1 check passed
@sudonatalie sudonatalie deleted the compound-eval-order branch February 26, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants