Harden eigh benchmark against content memoization#167
Draft
nataliakokoromyti wants to merge 2 commits into
Draft
Harden eigh benchmark against content memoization#167nataliakokoromyti wants to merge 2 commits into
nataliakokoromyti wants to merge 2 commits into
Conversation
Author
|
@msaroufim this affects the currently deployed |
Member
|
Thanks @nataliakokoromyti i'll take a look! Altho unlikely to merge given its final hours, will just rely on a manual audit to declare the true winner and delete reward hacks in the top 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The current evaluator clones inputs for warmup, then repeatedly times the original tensors with identical contents. Cloning changes object identity but does not prevent content-based memoization, so an output learned during warmup can be returned inside the measured region.
This is stronger than the clone/shuffle mitigation discussed in #102 because every measured call receives data that has not appeared in warmup or an earlier repeat.
Validation
The regression performs two benchmark invocations against one logical case (matching leaderboard prewarm plus scoring), requests 60 repeats each, and verifies the 50-repeat ceiling. It observes 102 unique generated seeds and zero content-cache hits.
A CUDA smoke on an NVIDIA L40S exercised the patched evaluator with 50 inputs per batch:
Fresh generation remained outside event timing. L40S wall times for one generated benchmark input were:
The 50-repeat ceiling bounds this added wall time under the existing 900-second timeout. A B200 smoke was attempted but the configured Modal workspace could not provision because its billing-cycle spend limit was reached.