feat(sheets): add --range flag to +append for tab selection#641
feat(sheets): add --range flag to +append for tab selection#641YunChaoTsai wants to merge 1 commit intogoogleworkspace:mainfrom
Conversation
Previously +append always used hardcoded "A1" range, limiting appends to the first sheet. Add optional --range flag (default: "A1") to allow appending to any sheet tab using A1 notation.
🦋 Changeset detectedLatest commit: 5ad1893 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the flexibility of the sheets +append command by enabling users to specify a target range for data insertion. By introducing the --range flag, users can now direct appends to specific tabs within a spreadsheet, rather than being restricted to the default first sheet. The changes include necessary updates to the CLI argument parsing, internal request construction, and comprehensive documentation to support the new functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request introduces a new --range flag to the gws sheets +append command, allowing users to specify a target range or sheet tab in A1 notation (defaulting to "A1"). The changes include updates to the CLI argument parsing, the internal configuration structure, request building logic, and comprehensive test coverage for the new parameter. Documentation in SKILL.md and a changeset file have also been updated to reflect these changes. I have no feedback to provide.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds a --range flag to the gws sheets +append command, allowing users to specify a target sheet tab or range in A1 notation. The implementation involves updating the AppendConfig struct, the argument parser, and the request building logic to support this parameter, which defaults to 'A1'. Documentation and tests have also been updated to reflect these changes. I have no feedback to provide.
d7a17b0 to
5ad1893
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new --range flag to the sheets +append command in the Google Workspace CLI, allowing users to target specific sheet tabs using A1 notation. The implementation includes updates to the command-line argument parsing, the AppendConfig structure, and the request construction logic, alongside expanded unit tests and documentation. I have no feedback to provide as there are no review comments to evaluate.
Summary
--rangeflag tosheets +appendhelper, allowing users to target specific sheet tabs via A1 notation (e.g.--range 'Sheet2!A1')"A1"range, limiting appends to the first sheet"A1"for backward compatibility+readexamples to use single quotes for range values containing!Test plan
cargo test -- sheets)--range)--range 'hihi!A1')--range '中文的!A1')--json-valuesand--range🤖 Generated with Claude Code